This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) Filtering the dblog messages (and then resetting the filters).
2) Looking at dblog when no messages are present.
3) View details about a log message.

CommentFileSizeAuthor
#8 dblog-filters.test.patch3.57 KBBrigadier
#5 dblog-filters.test.patch3.57 KBBrigadier

Comments

dmitrig01’s picture

dmitrig01 commented
Assigned: Unassigned » dmitrig01

Mine.

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests needed: dblog.admin.inc » TestingParty08: dblog.admin.inc
Assigned: dmitrig01 » Unassigned

Requisitioned.

lilou’s picture

lilou commented

See also #298444: DBLog tests exceptions

Brigadier’s picture

Brigadier commented
Component: tests » dblog.module
Assigned: Unassigned » Brigadier

Working on it.

Brigadier’s picture

Brigadier commented
StatusFileSize
new dblog-filters.test.patch3.57 KB

Here's a patch for part 1. It tests filtering with each severity level.

Part 2 was already done at line 390 of dblog.test (message is "DBLog contains 0 records after a clear.")

Part 3 was already done at line 153 of dblog.test (message is "DBLog event node was displayed")

naxoc’s picture

naxoc commented
Status: Active » Needs review
naxoc’s picture

naxoc commented
Status: Needs review » Needs work

I took a look and it looks fine. I only have one small thing that I saw was one comment that did not have the first word capitalized: "reset the filter, we should see excluded messages too".

Brigadier’s picture

Brigadier commented
Status: Needs work » Needs review
StatusFileSize
new dblog-filters.test.patch3.57 KB

Thanks, fixed it.

naxoc’s picture

naxoc commented
Status: Needs review » Reviewed & tested by the community

Took another look and I think it looks good :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

I am getting an issue #445482: Convert dblog_build_filter_query() to DBTNG with a fresh install of core head.

Not sure if this helps or not.

Brigadier’s picture

Brigadier commented

Yeah, I just did a simplified test case and my unit test is actually detecting a bug in dblog.module. When I use dblog_watchdog() to create a log message with a custom 'type' string, filtering at admin/reports/dblog causes the exception you've described. Now I have to figure out if that bug is actually filed yet.

deekayen’s picture

deekayen commented
Status: Needs work » Closed (duplicate)

I merged this into #445482: Convert dblog_build_filter_query() to DBTNG