This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) Proper validation of admin settings.

CommentFileSizeAuthor
#2 upload_adminsettings.patch6.85 KBarjenk

Comments

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests needed: upload.admin.inc » TestingParty08: validation of upload module settings
arjenk’s picture

arjenk commented
Status: Active » Needs review
StatusFileSize
new upload_adminsettings.patch6.85 KB

The upload settings page has the following settings:

  • Maximum resolution for uploaded images: WIDTHxHEIGHT
  • List files by default: yes/no
  • Default permitted file extensions:
  • Default maximum file size per upload:
  • Default total file size per user:

Currently tested are

  • Maximum resolution for ... see the user.test
  • default permitted file ... in upload.test
  • Default maximum file si... in upload.test

This patch adds tests for the settings:

  • Default total size per user
  • List files by default

as a side note: the upload module settings are now slightly off due to 1000/1024 differences #267883: parse_size() and format_size() do not use same kilo standard. I did not make a test for this but there should be one, somewhere.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Component: tests » base system
Category: bug » task
Priority: Critical » Normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.