TestingParty08: Filter administration

Been working on this, but we didn't get it done before the session ended..

This patch covers the following:
2) A format with no filters.
3) Attempting to add a duplicate filter name.
4) Attempting to delete the default filter.

Patch written with help from mikl.

The first one seems to have already been done.

Sweet, good job grndlvl :)

Looks pretty good and the tests run fine. Couple of minor code style issues before this is RTBC - inline comments should be written as sentences (start with capital letter, end with full stop), also we usually use $edit as the variable name for form values in drupalPost (although I'm not sure if that's a standard or just habit tbh) - and the $cannot_delete_text look unnecessary to me - about the same number of characters as putting the t calls in assertText() directly. Nice work though :)

Made changes mentioned in comment #6.

-Do not really want to change variable name on line 151 to $edit from $empty_format because $empty_format is used throughout the rest of the test. And $edit is too arbitrary to be used throughout the test.

$empty_format was my bad, my eyes clearly weren't working properly. Other changes look good and the tests run fine, so marking RTBC.

Code style stuff:

+    // Create format with no filters.
+    $empty_format = array(
+        'name'     => $this->randomName(),
+        'roles[2]' => 1,
+    );

Those look indented too much; possibly tabs?

+    $this->assertRaw(t('Added input format %format.', array('%format' => $empty_format['name'])), t('New empty filter created.'));

It's an empty format, not an empty filter.

+    $node_body =  $random_text. '<?php print "'. $random_text .'"; ?>'. $random_text .'<img src="'. $random_text .'" />'. $random_text; 

We concatenate with ' . ' (space on either side of the dot). There are a couple other places this needs to be changed as well.

+    $this->assertRaw($node_body, t('Everything comes across and php not eval-ed.'));

Capitalize PHP, I don't quite grok "eval-ed".. do you mean 'executed'? Come to think of it, I don't really understand this message in general. Could you be more specific about what exactly is being tested here?

In general, I'd like to see these test cases split up into separate functions rather than in one big monster list, with the code that needs to be shared between them moved to a setUp() function. Use the DB tests and the file tests, both of which were most recently added, for a guideline on how to split things up.

Began working on suggestions from #9, ran into issues with two of the tests. Kind of late here going to bed just placing new patch work up just in case someone felt like working on it until I get to the problems.

Made changes suggested by #9 throughout the whole test.

Fixed patch. Was not done from docroot :/ whoops.

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

Most of this is already covered in HEAD.

However, some of the introduced test functions are really good ideas. So let's re-roll this sucker and get it in.

Most if not all of this is already in Drupal\filter\Tests\FilterAdminTest. Filter module's test coverage has been expanded quite a bit since 2010. Closing.