When deleting a node, the function modules/menu.module:menu_node_form_delete() removes a custom menu entry for the node if it exists. The problem is that it will always print a message about a removed menu item, even though nothing has been actually deleted. Suggested fix: use db_affected_rows().

CommentFileSizeAuthor
#4 node_delete_status.patch679 bytesax
#2 node_delete_menu_msg_1.patch582 byteswiz-1
node_delete_menu_msg.patch583 byteswiz-1

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Active » Needs work

we use && not "and".

wiz-1’s picture

wiz-1 commented
Status: Needs work » Needs review
StatusFileSize
new node_delete_menu_msg_1.patch582 bytes

ok I changed and to &&

jose reyero’s picture

jose reyero commented

+1 Patch looks good

ax’s picture

ax commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new node_delete_status.patch679 bytes

this is annoying behaviour, indeed, especially when you mass delete nodes. you get a status message like this:

The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The menu item has been removed.
The items have been deleted.

this is a) in the mayority of cases plain wrong, as no menu items got deleted, and b) misleading: you didn't want to delete menu items but nodes, did you?

we don't show status messages for other node_api delete operations (comments etc.), so i'd suggest to just ommit the menu item message. patch attached.

please consider this for 4.7, as it certainly is a usability issue. thanks!

m3avrck’s picture

m3avrck commented

Agreed :) Code wise, makes sense to me, the message does seem a bit superflluous.

dries’s picture

dries commented

Removing the status message sounds like the best solution. I didn't expect such a status message in first place.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)