Posted by jonhattan on June 30, 2008 at 1:02pm
Jump to:
| Project: | Hidden |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Attached is a patch to upgrade to drupal 6.
I've not intensively tested all the features but those typical ones works: hide/unhide; create reasons and filters. View hidden content listings and individual hidden nodes / comments.
Also to say that I was a bit lazy and simply removed the upgrade code in hidden.install
| Attachment | Size |
|---|---|
| hidden_upgrade_to_6x_patch.diff | 62.63 KB |
Comments
#1
I'm pretty sure you should just have one hook_schema() with all the tables.
Btw, in doing the upgrade to Views 2, it would be nice to figure out a way to avoid the hook_boot() so aggressive caching could be used. Views 2 will automatically load module.views.inc and module.default_views.inc files when needed.
#2
Jonhattan nice one for this cheers!
I've moved the install schema round as suggested by mfb. I've fixed some Drupal 5 to 6 things that Coder picked up: l() arguments, un-needed t(), hook_help. And I've then committed this to CVS HEAD.
Still to do certainly there are some FAPI changes still to go in, this is surely the reason why the redirect after hiding isn't working any more. It may also be why the free text field reasons for hiding are not being stored in the database.
I've also merged DRUPAL-5--2 to HEAD so the hidden.views.inc file is there and can be worked on as well.
It probably makes sense to split some of the rest of the module up into separate .inc or even separate modules so users can pick and choose - especially with views being able to duplicate some of the UI functionality. I'll make some new issues, and try and work on this sometime paid work gives me a break!
#3
Update:
* break up into files different include files done
* started to fix FAPI the hidden.action-pages.inc file is done (which is the really important bit as it actually lets you hide things ;-)
All still in HEAD but nearing the point a D6 branch and dev release would make sense.
#4
Update:
* All user pages, and admin configuration pages done.
* Tests written for all of above
ToDo before first release:
* Tests and fix any bugs for admin action pages (node and comment admin list pages).
Then:
* actions, views2