Support for organic group

Yes, this would be a nice feature. I've been developing a site using OG. I'd be interested if you uploaded your patches.

I prefer the patches to be cvs based differences. See the http://drupal.org/handbook/cvs guide if you need help with that. Or just ask me.

Yes adding OG filtering logic would be good.

Please add some docbook/doxygen comments to the new functions. One of the near future goals is to be standard with coding and to be able to look at http://drupal.kollm.org/doxygen/_contrib/drupal-contrib-phpdoc/dirs.html, find advuser and see http://drupal.kollm.org/doxygen/_contrib/drupal-contrib-phpdoc/advuser_2... to get the documented version of the module.

Your JOIN + $result = db_query('SELECT node.nid as nid, title FROM {node} JOIN {og} WHERE node.nid = og.nid'); needs to use ON instead of WHERE and I like to read the joined criteria on the left. + $result = db_query('SELECT node.nid as nid, title FROM {node} JOIN {og} ON og.nid = node.nid'); But this still isn't enough, since {node} and {og} are replaced with a defined $prefix the statement will fail in those cases where $prefix is defined. The fully corrected version is: + $result = db_query('SELECT n.nid, n.title FROM {node} n JOIN {og} og ON og.nid = n.nid'); Your other queries suffer from the same $prefix fate.

When you upload your new patch please change the status to "patch (code needs review)".

Your new functions still need some phpdoc documentation.

/**
 * Example phpdoc documentation
 *
 * @param int $someint
 *  Provide an param sample
 * @return bool
 *  Operation status
 */
function somefunction ($someint) {
 if ($someint) {
  return TRUE
 }
 return FALSE
}

You might want to check http://manual.phpdoc.org/HTMLframesConverter/DOM/default/ or http://www.stack.nl/~dimitri/doxygen/docblocks.html. I plan to test your patch further beginning Monday.

Thanks for testing and the report. Ivica had mentioned that he was working on a patch for filtering by OG as well. I'm looking forward to it. I've been currently too busy with other things in life and haven't had a chance to give this more attention. We still need the phpdoc documentation comments.

Thanks for the patches. I'm out of cycles for August though I'm afraid. I'll have to review them later.

I began just yesterday looking at redesigning the filter options form. I'll take a look at this eventually.

Pushing feature request to 7.x version.