"X" mark (close) is wrong formatted in Firefox 2.0.0.14

se - June 30, 2008 - 19:12
Project:Lightbox2
Version:6.x-1.8
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

After update 1.7-> 1.8 is "X" for close photo formatted approx in 1/3 of photo width, bottom outside photo and there is always horizontal scrollbar when lightbox is actived.

Checked v1.8 in IE7 and it works correctly..

#1

stella - June 30, 2008 - 19:53

Ah, I changed it because it stopped appearing correctly for me. I guess it's because I've upgraded to FF 3. Let me look into it further.

Cheers,
Stella

#2

gumdrop - June 30, 2008 - 20:54

I am getting that same issue in Firefox 3 also.

#3

stella - June 30, 2008 - 22:05

No, I can't reproduce it in FF 3. I've tried 3 different windows machines running FF3 and it appears in the correct place. What platform are you using?

#4

gumdrop - June 30, 2008 - 23:26

Well it is certainly doing it for me. And I tried it with different themes/templates. The previous version was fine.
I am using the image node settings enabled.
However, no horizontal scroll bar. Just the x outside the frame as above...below the enlarge link.

#5

se - July 1, 2008 - 08:33

Here is cropped screenshot, perhaps it helps ...
As for me, I am running FF2 on win xp..

#6

stella - July 1, 2008 - 10:23

I still can't reproduce it and I'm using the default garland theme.

Can you send me a link to your site? My contact form is enabled if you wish to do so privately.

Cheers,
Stella

#7

stella - July 1, 2008 - 11:30
Status:active» fixed

The attached patch should fix the issue. I still can't reproduce it on my test site - I've tried both versions of FF on 4 different machines, with 6 different themes! There must be something about my test site because I've since tried it on a different D6 site and I can reproduce your issue.

Anyway, attached patch should resolve the issue and I've committed it to CVS so it should appear in the next dev release, later today.

AttachmentSize
lightbox2_276891.patch668 bytes

#8

stella - July 1, 2008 - 11:42
Category:support request» bug report

Ignore last patch. Found the proper solution. The issue I was having on my site only affected multi-lingual sites which is why I couldn't reproduce the issue. The attached patch should work for all sites now. Firebug is very useful!

Cheers,
Stella

AttachmentSize
lightbox2_276891.patch1.04 KB

#9

se - July 1, 2008 - 14:11

Patched .. "X" is fine now , but there is always horizontal scrollbar.. I browsed in gallery for while and scrolled area(even vertical) is getting larger after every prev or next click.. looks like something is incremented or added by browsing in lightbox??

#10

gumdrop - July 1, 2008 - 14:49

That fixed it for me on my FF3. Only time I get scroll bars is if I am using the html content. Which I think should be normal.

#11

stella - July 1, 2008 - 15:17

The attached patch should fix it - note you need to use this patch as well as the one from comment #8 above in order to fix both issues. This one just resolves the scrollbar issue.

gumdrop: the scrollbar issue is the firefox window scrollbars, not in the lightbox itself.

It was caused by what I believe to be a bad interpretation by Mozilla of window.innerHeight and window.innerWidth which includes the scrollbar's width in it's calculation! Anyway the attached patch has a workaround for this.

Cheers,
Stella

AttachmentSize
lightbox2_scrollbar_276891.patch1009 bytes

#12

se - July 1, 2008 - 16:05

Stella,

great work! Patches are applied and both solved announced issues..

Thanks!

Tomas

#13

stella - July 5, 2008 - 14:17

I've had to roll back the scrollbar patch. It doesn't work reliably and I think it's better to have a bad scrollbar length rather than the overlay not covering the full page. Sorry.

Cheers,
Stella

#14

UCFPowell - July 6, 2008 - 00:04

Has there been an update to Lightbox2? I downloaded it today, and have the issue mentioned above. My X appears below the photo.

http://www.jetblackmotorsports.com/ourfacility

#15

UCFPowell - July 6, 2008 - 00:12

Nevermind I fixed it. I removed the second line with the 29% width.

#imageData #bottomNav { lightbox.css (line 153)
height:66px;
width:29%;
}

#16

stella - July 6, 2008 - 10:42

UCFPowell: it's currently still only available in the dev version.

#17

Anonymous (not verified) - July 23, 2008 - 10:56
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#18

hansamurai - September 9, 2008 - 02:48

I know this is closed but there's a side effect from leaving the scroll bar issue be: when I use the right arrow key to go to the next image, the screen stretches more and the lightbox moves further and further to the left as the window expands to the right.

I don't feel like it is appropriate to re-open this issue because of that, more of a heads up.

#19

loloyd - September 30, 2008 - 01:11

Thanks to UCFPowell for the quick fix on the "ugly" placement of X (close lightbox) button. Thanks to Stella too, of course, for making Lightbox2 module as powerful as it is now. Removing the "width:29%;" bit (or at least commenting) on line 155 of the file css\lightbox.css transfers the X button to the bottom-right side of the lightbox making things less uglier, aka prettier :-D.

Sorry for sounding awfully newbish but I also found that the "width:29%;" bit does not appear in the file css\lightbox-rtl.css. Shouldn't it be duly removed from the file "css\lightbox.css" as well?

#20

stella - September 30, 2008 - 07:55

If you use the latest dev version of the lightbox2 module, the correct lightbox css files are included, so you have no need to make changes. It also fixes a couple of other issues too.

 
 

Drupal is a registered trademark of Dries Buytaert.