Sorry, I have so many changes in my weblink.module, it is hard to produce a clean patch.

in weblink_validate, around line 175:

elseif (isset($node->title) && (trim($node->title) == '')) {
  form_set_error('url', t('You have to specify a weblink.'));

Should the second part of the elseif statement being doing a comparison on $node->url instead of $node->title?

CommentFileSizeAuthor
#2 weblink-validate.patch588 bytessamo

Comments

Bèr Kessels’s picture

Bèr Kessels commented

yes. correct. please send in a patch.

samo’s picture

samo commented
Status: Active » Needs review
StatusFileSize
new weblink-validate.patch588 bytes

patch attached

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Fixed

thanks. your patch contained an errir (you forgot the first variable) but I fixed and committed that. Thanks! Oh, and also backported to 4.6

samo’s picture

samo commented

sorry, i thought the first part was purposeful... i.e., don't set the error attention on url unless the title is also set

tihp’s picture

tihp commented
Anonymous’s picture

(not verified) commented
firedancer5’s picture

firedancer5 commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)