custom_breadcrumb does not set active menu item

suit4 - July 1, 2008 - 11:22
Project:Custom Breadcrumbs
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

First: great mdoule, very powerfull! Thanks a lot!

Second:
I heavily use taxonomies to build my site along with taxonomy_menu, taxonomy_redirect and other stuff.
I even moved menus created by taxonomy_menu inside of other menu items, which are not create by taxonomy_menu (and it works nicely).
To tweak the breadcrumbs to some of my content nodes, I used custom_breadcrumbs using tokens, which works much better as expected :) .

So, when I now navigate through my menu, going into taxonomy based menu, I come to a single node - the last element in the menu hierarchy. If that node is active, all menus get closed, so the elements position inside the menu is not shown anymore, which is a usability problem. The breadcrumbs are still displayed correctly.

I was wondering, that if the breadcrumbs display correctly, the menus should, too.

I integrated a bit of code into your module including a menu_set_active_item() to force the menu to display the correct location.

Patch attached.

I you think, this is not a bug, then I request this as a feature!

AttachmentSize
custom_breadcrumbs_set_active_item.patch1.19 KB

#1

MGN - September 19, 2009 - 04:53
Version:5.x-1.2» 5.x-1.x-dev
Status:active» fixed

Just committed something very much like this patch to 5.x-1.x-dev. Thanks.

#2

MGN - September 19, 2009 - 06:19

Ooops. There was a problem with this approach mentioned in #124390: Highlight current menu item so I went with the patch in that issue instead.

#3

System Message - October 3, 2009 - 06:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.