include a patch for taxonomy.module

christefano - July 1, 2008 - 12:18
Project:Leftandright - Nested Set Taxonomy
Version:5.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

It would be helpful to have a patch instead of a modified taxonomy module (I'm thinking of when when a new version of Drupal is released or if a Drupal installation already has a modified taxonomy.module). Thanks.

#1

sdrycroft - July 1, 2008 - 16:05
Status:active» fixed

I deliberated doing exactly this, but decided that including just the replacement file was simpler. I've included the patch file below, which shows how simple the changes to the taxonomy.module file are, and also shows how easy this will be to update if a 5.8 version of Drupal is released.

AttachmentSize
taxonomy.module.patch 1.24 KB

#2

christefano - July 1, 2008 - 23:54

Will you be including the patch with a future release? Sorry, that's what my issue is really about. Creating a patch is easy but including one in the package would save many people a lot of time.

#3

sdrycroft - July 2, 2008 - 11:57

No, I won't include the patch in future releases, the file itself is included.

#4

christefano - July 2, 2008 - 16:18

I deliberated doing exactly this, but decided that including just the replacement file was simpler.

I listed a few reasons why it isn't simpler, but in the end it's up to you. Thanks for contributing an interesting module.

#5

Anonymous (not verified) - July 23, 2008 - 10:56
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#6

christefano - July 23, 2008 - 23:03
Status:closed» won't fix

#7

sdrycroft - July 24, 2008 - 12:17
Status:won't fix» fixed

Patch ↑

#8

Anonymous (not verified) - August 7, 2008 - 12:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.