Apparently this patch renamed "Primary links" without catching all the places the "primary-links" menu named is used: #270917: UB Usability : Labeling primary link label.

visiting the page: admin/build/menu/settings

I get:

notice: Undefined index: main-menu in modules/menu/menu.admin.inc on line 633.

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Postponed (maintainer needs more info)

This seems to be the order of events:

$menu_options = menu_get_menus()
$main_options = array_merge($menu_options, array('' => t('No Main menu')));
(line 633) array('%main' => $main_options[$main]))

All I did was a find and replace on this, so not looked at the code in much depth, however I can't see a primary links missing here. One possibility - is your database quite old, if it is, did you run update.php?

pwolanin’s picture

pwolanin commented

hmm, maybe? I'll try from a fresh install.

catch’s picture

catch
he/him
Primary language English
commented

Note that apart from changing the variable names, there's no upgrade path to change menu names themselves on old installs, but at the time I was convinced this was both unnecessary and a bad idea. Ought'nt to be an issue but worth mentioning.

pwolanin’s picture

pwolanin commented

hmm, we did a 5->6 upgrade. Without one people will be sad that their links all go away, won't they? Or will they be fine due to the variable settings?

catch’s picture

catch
he/him
Primary language English
commented

As far as I could work out, the variable and old Primary links/Secondary links ought to be maintained and continue to work - just as if you'd put custom menus there. IMO it'd be like renaming 'Story' to 'Article' in an upgrade path - no point messing with admin-alterable stuff on existing sites. 5-6 updates were more about ensuring things worked after the refactoring (although I don't remember the reason for that specific update).

pwolanin’s picture

pwolanin commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

ok then.