PATCH: fix undefined value warning

eMPee584 - July 1, 2008 - 14:53
Project:modr8
Version:6.x-1.0-beta2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

hi there,
attached patch fixes a warning (E_ALL) when you visit the Views module page... thought i better quickly submit this before i forget.. regards!

AttachmentSize
modr8-fix-undefined-value-#value.patch440 bytes

#1

pwolanin - July 2, 2008 - 21:10

can you please re-post the patch without a # in the name? I cannot open the link because of that.

#2

eMPee584 - July 5, 2008 - 16:09

wow that's true sorry.. *g

AttachmentSize
modr8-fix-undefined-value-value.patch 440 bytes

#3

NikLP - September 4, 2008 - 12:05

Is this going anywhere? Is it in dev? HEAD?

#4

pwolanin - September 5, 2008 - 00:46
Status:needs review» fixed

committed - thanks

#5

eMPee584 - September 7, 2008 - 12:05

cool thx pwolanin... btw would you mind to also make 6.x-dev releases on each CVS commit? don't know how much work it is but it helps stay on track, f.e. my little update script uses the date of dev tarballs to slurp newest ones off the server..

#!/bin/sh
IFS=''
echo "`date`">update.log
for file in *.tar.gz
do
        cp -p $file $file.tmpcpy
        wget -N --no-proxy http://ftp.drupal.org/files/projects/$file >>update.log 2>&1
        if [[ "$file" -nt "$file.tmpcpy" ]]
                then
                tar -xzf $file
                echo "$file updated"
        fi
        rm $file.tmpcpy
done

#6

NikLP - September 7, 2008 - 12:43

Again, there are still no clues as to "where this is fixed" - can someone PLEASE add this information? Lots of people are trying their hardest to use 6.x stuff. Modules are all over the place, still, and lack of this kind of information is just confusing as hell.

Many thanks.

#7

eMPee584 - September 7, 2008 - 13:15

NikLP don't quite now if i understood you correctly, but if you meant that literally, pwolanin has committed this to CVS HEAD, which is the only place to get it because this module does not yet have a dev release. It's only a silent warning anyways so please calm down ;)

#8

pwolanin - September 7, 2008 - 13:20

eMPee584 - if you want to stay current like that, I'd suggest deploying via CVS.

I'll push a 1.0 with this fix anyhow.

#9

eMPee584 - September 9, 2008 - 10:34

nah CVS has them stupid hidden folders ;)
but almost all packages i have installed do -dev-releases so except for a few my method works nicely.

#10

Anonymous (not verified) - September 23, 2008 - 10:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.