make format_name themable [#27737]

Comment	File	Size	Author
#9	theme_username_0.patch	20.14 KB	killes@www.drop.org

#4	theme_username.patch	20.05 KB	killes@www.drop.org

	theme_format_name.patch	20.39 KB	killes@www.drop.org

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 29 July 2005 at 01:50

makes sense to me.

Log in or register to post comments

Comment #2

Steven CreditAttribution: Steven commented 29 July 2005 at 03:33

theme('format_name') is a bit weird... why not have theme('name') ?

Oh and this might be a good time to change it so that it uses drupal_substr() and drupal_strlen() to cut off the username. This would mean the visual string length before chopping is more consistent.

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 29 July 2005 at 06:45

Better would be theme('username'), I think. "format_" is redundant in combination with "theme", but "name" is a bit too generic a name, I'd say. Otherwise it looks good. Not tested though.

Log in or register to post comments

Comment #4

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 29 July 2005 at 11:48

File	Size
theme_username.patch	20.05 KB

Ok, implemented the suggested changes.

Since it did get such a warm welcome, how about doing the same to the format_date function and removing the various settings (everythign but time zone) associated with it?

Log in or register to post comments

Comment #5

Bèr Kessels CreditAttribution: Bèr Kessels commented 29 July 2005 at 12:01

I tried this patc hon a dutch localised system. It works as expected. I like it.

A question though, which also applies to the recently introduced patch to move date settings to locales:
Unglish native speakers will now need to enable localisation, just for the sake of changing small things like the date, or, in this case, the name.
However, personally I do not really mind that, since I use locale on all my sites anyway. But others might not like that (performance) penalty. Ideas?

Log in or register to post comments

Comment #6

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 29 July 2005 at 12:10

thanks for testing.

Why do you think that you'd need to enable locale.module for changing the name?

You need to implement a themable function in your theme, that's it.

Log in or register to post comments

Comment #7

Bèr Kessels CreditAttribution: Bèr Kessels commented 29 July 2005 at 15:59

NM. just me being confused. I have been workingon some complex (multilinugal) things lately. Somehow that flooded my mind. I guess.
I tested this, to theme an icon of teh user (avatar) in front of the usernames. on newsphoto.nl we want to present everyone with images. (teh dev site is not public, so I cannot show the result, yet)