If I open the page admin/panels/panel-page/Test/edit/context the content could be to wide for a page. This will be the case if you have imported the German translation and you use a theme uses overflow:hidden in the main column where the panels are embedded.

See the attached sceenshot that also shows issues with to bug submit buttons. This bug also looks like #186295: admin: layout-container moving outside the page what I reported sometime earlier and have been fixed, but I haven't verified if this is the same issue, yet.

In this case I would say it is better to move the boxes among each other. This could be done by floating the boxes... it would really solve the issue with strings that could become longer as the English ones in other translations.

CommentFileSizeAuthor
#8 D5_panels_fix_broken_contexts_page.patch3.81 KBhass
panels_bug1.png30.14 KBhass

Comments

sdboyer’s picture

sdboyer commented

Patch?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

You should use a theme that supports Panels, or, if this is a custom theme, adjust it to support Panels.
Sorry, Panels simply can't support everything out of the box.

hass’s picture

hass commented
Status: Closed (won't fix) » Active

@Sun: The main issue is that panels is not aware that a translation may change the size of all boxes, buttons, etc. This is the only case here! I will test the same in garland with German translation and I'm sure the same issues occur. Panels UI must float the boxes if content becomes toooo big.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Content becomes hidden in some themes » Broken contexts page layout due to overflowing table contents

Well, based on the posted screenshot, I'd say that the translation is guilty here, because the select field contains whole sentences where only a two-word phrase would normally be.

On another thought and taking #187639: Panels Token Contexts into account, we might have longer select options one way or the other.

The solution for this rendering bug is to apply a width to the table columns, but also some width + overflow magic to the select options.

Better title.

hass’s picture

hass commented

Well the translation is not the best here... and the German panels translation is far away from ready, but it shows an important and typical issue.

Aside do you have a better German translations for:

Node add form => Formular zum Erstellen eines Beitrages
Node edit form => Formular zum Bearbeiten eines Beitrages
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

There are quite a few alternatives and I'd vote for the 3rd:

1. Formular zum Bearbeiten eines Beitrages
2. Beitragsbearbeitungsformular
3. Formular: Beitrag bearbeiten
4. Beitrag bearbeiten-Formular

However, let's stay on focus in this issue, please.

hass’s picture

hass commented
Version: 5.x-2.0-beta5 » 5.x-2.x-dev
Status: Active » Needs review

This patch reliable fixes this overflow hidden issue in all thinkable languages and however long the Identifier text becomes.

1. It removes the left/right containers to have some more space for longer strings. This is much better than the broken stuff today (see the attached screenshot).
2. Additional it moves the "Save" button to the very bottom what makes usability much better.

I also struggled myself about this "cannot save" usability issue and overseen the save button when I've added a required context and wondered why it was marked yellow with a star telling me I should save, but the save button was not below the table. This also ended with a error after I clicked on context tab and the page reloaded without the new context saved. See #307896: Unsaved context causes error in modal window.

hass’s picture

hass commented
StatusFileSize
new D5_panels_fix_broken_contexts_page.patch3.81 KB

Re-attach missing patch. Something wrong with d.o uploads?

dellintosh’s picture

dellintosh commented
Status: Needs review » Reviewed & tested by the community

Applied patch, works great! :)

-dellintosh

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review

This patch needs way more positive test results from other users. Hence, marking as PNR.

Also, I'm reluctant to support this patch for two reasons: The German translation of Panels is a pain in general and is better redone from scratch. Since it was the cause for this issue, I'd rather fix the cause than something else. Secondly, a change like this might be needed if we'll add #187639: Panels Token Contexts anyway, but then again, my suggestion in #4 for fixing this issue without changing the whole layout has not been addressed with a single word, and I still think that this would be a better fix.

hass’s picture

hass commented

@Sun: The translation wasn't the issue here. It only shows that the layout is not designed to allow longer texts what will happen very often and in every language other than English or less wider layouts like minelli.

And also, please keep in mind the German Panels translation is "work in progress". I don't think it is such bad as you say until you point something out and I cannot remember. If you see issues - send me an email and I will review it. Everything that is translated should be ok, except some #fuzzy stuff, but please also understand that I'm not willingly to work on this buggy module if translation fixes are not going in and staying in queue for 2 months without any comment. I reviewed the module for the translatable strings and I assure you this is not easy to translate. It would need a complete UI review and a *super monster* patch to get fixed. Translation of panels is today a VERY hard job that cannot be done without code reviews of every damn string. Very bad job, but you can take it and I will review your work on this bad strings.

esmerel’s picture

esmerel commented
Status: Needs review » Closed (won't fix)

No fixed to be committed to the 2.x line

hass’s picture

hass commented

Same issues are in 6.x as I know...