Closed (fixed)
Project:
Nitobe
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Reporter:
Anonymous (not verified)
Created:
2 Jul 2008 at 13:22 UTC
Updated:
3 Dec 2018 at 14:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eaton commentedHere's an experimental CSS tweak that allows the theme to expand to its full width if there's no content in the right sidebar. At one point it does override the grid_* width, which is less than ideal, but it also restricts it to what's going on inside the #content div.
Comment #2
Anonymous (not verified) commentedHaven't had a chance to review this yet. Will look at it this week.
Had to comment so it wouldn't close automatically before I looked at it.
Comment #3
daniel-san commentedUpon applying patch received following failure:
patching file style.css
Hunk #1 FAILED at 246.
Hunk #2 succeeded at 447 with fuzz 1 (offset -96 lines).
1 out of 2 hunks FAILED -- saving rejects to file style.css.rej
Text from style.css.rej:
Hope this helps.
Dan
Comment #4
Anonymous (not verified) commentedDan,
Thanks for trying the patch. The code has changed a lot since Jeff submitted this patch, so it's not likely the patch would work as designed even if the patch applied correctly.
I'm also not sure at this point that anyone even wants this feature. Were you trying the patch because you had need of a full-width version?
Thanks,
Shannon
Comment #5
daniel-san commentedShannon,
Yea, I would definitely want to have the theme work at full width when not using sidebars. I just haven't had the time to work on the css to make it happen. Work projects coming in front of personal, ya know.
Thanks for the information and if I get a chance to work on it, I will update what I've done to make it full width.
Take care,
Dan
Comment #6
Anonymous (not verified) commentedDan,
Since the CSS is based on a grid system, doing this at the CSS level will be nasty.
I'm planning to handle this using a deterministic approach similar to what I did with Hiroshige.
Shannon
Comment #7
daniel-san commentedOk Shannon. Thanks for letting me know.
I really appreciate the work you guys have done on this theme.
Comment #8
Anonymous (not verified) commentedDan,
I've checked in some changes to CVS that provide a full-width layout if the sidebar isn't present. There is some weirdness in the block listing page (admin/build/block) if there is nothing in the sidebar, the region names appear below the block list. This isn't a big issue, however.
I won't roll a new release though until I've had a chance to resolve #283329: Bad CSS styles for dl, dt, and dd elements
Shannon
Comment #9
markDrupal commentedHere is a new patch that accomplishes the same thing
Comment #10
Anonymous (not verified) commentedMark,
It's not quite the same thing. Any element that has the class
grid_12needs to always be 12 columns wide. If it's 16 columns wide, it needs to have the classgrid_16. The goal is to stay within the semantics of the grid system that is being used.Comment #11
Anonymous (not verified) commentedThis was implemented in a prior release.
Comment #12
Anonymous (not verified) commented