This is more a proposal than a feature request. The patch removes the arrow image and sets a class expanded/collapsed on the span, so it can be styled in the theme css.

CommentFileSizeAuthor
#6 cart_block_css_images.patch10.58 KBrszrama
#2 cart_empty.gif89 bytessvetlin
#2 cart_full.gif89 bytessvetlin
#2 uc_cart_1.patch6.82 KBsvetlin
uc_cart.patch5.26 KBsvetlin

Comments

rszrama’s picture

rszrama commented

Excellent patch! I'll consider dropping it in the 1.1, but it'll definitely go into the D6 branch. I'm curious if there's anyway I could get you to do the same thing for the shopping cart icon... it looks horrid on dark backgrounds, but a lot of people still use it. It's probably just b/c it's hard to figure out how to change or remove. : (

svetlin’s picture

svetlin commented
StatusFileSize
new uc_cart_1.patch6.82 KB
new cart_full.gif89 bytes
new cart_empty.gif89 bytes

I'm not sure this is the best solution, because the cart link is floated and goes over the block title if the user is using a very large font. The cart icon is a background image of the cart link, which has a cart-empty/cart-full class. I have removed some unnecessary classes from the css file and the uc_cart_path variable.
I have also attached two icons for the cart link, which I think more clearly indicate the state of the cart, but this is a matter of taste. If you like them, use them.

rszrama’s picture

rszrama commented
Status: Needs review » Needs work

I was about to commit this when I realized 2 things:

1) The images for the collapsed arrow are relative, but we can't assume everyone will put their Ubercart directory in the same place. I think the thing to do is going to be to duplicate the arrow graphics into the cart directory. Any thoughts?

2) I'd rather not switch up everyone's cart block images in a minor version... meaning, I needed to float the cart icon left instead of right, and I need to figure out how to get the collapsed arrow back on the right side. That part is proving difficult for me. ; )

Other than that, this is a great step in the right direction!

rszrama’s picture

rszrama commented

-duplicate-

rszrama’s picture

rszrama commented
Version: 5.x-1.0 » 6.x-2.x-dev
Issue tags: +theme layer
rszrama’s picture

rszrama commented
Assigned: Unassigned » rszrama
Status: Needs work » Needs review
StatusFileSize
new cart_block_css_images.patch10.58 KB

Patch attached for all cart block title images. : )

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Has been reviewed and committed.

Status: Fixed » Closed (fixed)
Issue tags: -theme layer

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +theme layer

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.