It seems like bad style to use <?php global $theme ?> in .tpl.php files. If $theme is needed in the page template, let's send it in as a variable so that it is consistent across all themes.

CommentFileSizeAuthor
global_theme_patch.txt1.9 KBrobertdouglass

Comments

robertdouglass’s picture

robertdouglass commented
Assigned: Unassigned » robertdouglass
robertdouglass’s picture

robertdouglass commented
Project: PHPTemplate » Drupal core
Component: Code » theme system
dries’s picture

dries commented

Is there any theme that uses the $theme variable? Only bluemarine seems to be using it and according to http://drupal.org/node/27791 it might be dead code.

Steven’s picture

Steven commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)