I've unchecked the admin setting "Create a menu tab for each node that could belong to any queues" and I have no nodequeues at the moment but there is still a Nodequeue tab on my nodes. Am I mistaken on what the setting does? There is no use of the variable nodequeue_use_tab outside of nodequeue_admin_settings() that I can see.

CommentFileSizeAuthor
#7 nodequeue_tab.patch2.04 KBezra-g
#3 nodequeue-use-tab-277867.patch1.53 KBcoltrane

Comments

coltrane’s picture

coltrane
he/him
commented

Would a variable_get() around the nodequeue tab item in hook_menu() do the trick?

coltrane’s picture

coltrane
he/him
commented

I tried this, but no it doesn't seem to be enough. Likely because of menu caching ... hmmn.

coltrane’s picture

coltrane
he/him
commented
Status: Active » Needs review
StatusFileSize
new nodequeue-use-tab-277867.patch1.53 KB

If the cache is cleared problem is solved. So, patch attached wraps the menu item in a variable_get() on nodequeue_use_tab. What's preferred, on submit of the admin setting do menu_rebuild() or tell the user (dsm or otherwise) to clear the cache themselves?

ezra-g’s picture

ezra-g commented

#289683: Queue Names Missing in node-edit-tab and #281040: Subqueue name changes don't affect individual subqueues may be symptoms of the same problem that this patch addresses.

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

While this patch should address cases where the site-wide setting is not observed, it does not resolve individual nodes that have tabs even though they are not eligible for any queues. That's because nodequeue_node_tab is being called regardless of whether a node is eligible.

ezra-g’s picture

ezra-g commented

I rerolled this and defined a custom nodequeue_node_tab access callback, which took care of the problem in more cases, however the tab still lingers in the menu cache after a node has become ineligible. We'll need to make this callback non-cache-able.

ezra-g’s picture

ezra-g commented
Status: Needs work » Needs review
StatusFileSize
new nodequeue_tab.patch2.04 KB

I think we got it here.

ezra-g’s picture

ezra-g commented
Status: Needs review » Active

The solution to this involves writing a new access callback function, and should have been incorporated into #278609: Forward port Modular Access Control to 6 . I will re-roll that patch to include this solution. Leaving this issue open as the bug described here is not a dupe.

ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Fixed as part of #278609: Forward port Modular Access Control to 6.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.