Closed (fixed)
Project:
Embed widgets
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Jul 2008 at 00:32 UTC
Updated:
23 Jul 2008 at 10:56 UTC
I'm not sure what the purpose of having the embed code in a separate menu item, outside of the admin menu, but even if it stays there (I don't think it should- I hate when modules automatically add themselves to the top level navigation menu) I think you should provide it on the admin page. Two places where it would be good are on the widget preview page and via a link under "Widgets" at admin->build->embed-widgets.
Comments
Comment #1
jtsnow commentedThe "Embed Widgets" top-level menu item was there in the D5 version. It's purpose, and why I have left it there until now, is that it makes it easy for non-admins to get widget code. The user interface will be much better by the time I'm done with it. I also dislike modules that add top-level navigation items, but a page where end users can customize widgets and grab the code will be necessary.
A menu item link may not be necessary if "embed" links are added to every page, block, and view, that have been added as sources. I'm not sure which is less intrusive, but I plan on making an "Embed Widgets Settings" page under Site Configuration to manage these sort of options.
As for now, the link has been removed and the embed code is available in the admin section on the widget preview page.
Comment #2
aaron commentedI like your reasoning, and see both sides of this issue. I think this would be a perfect place for MENU_SUGGESTED_ITEM.
Comment #3
aaron commentedbonus points if the admin can turn the menu on/off from an embed widgets settings page, instead of having to somehow magically know the suggested menu item is available. at the least, there should be a mention of it in the resulting documentation.
Comment #4
alex ua commentedI didn't mean to imply that the embed code should be available only on the Embed Widget admin section, just that it should it should be there as well.
Comment #5
alex ua commentedI'm going to go ahead and mark this as fixed, since the widget embed code is now on the admin page. We should open up a new issue in the near future to discuss where else the code should be available. (For example, I'd love a Views setting, argument, or something else that would allow you to have embed widget code on every page of the view, similarly to the Feed Selector argument)
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.