Screenshot 1/2. The modules admin page.

CommentFileSizeAuthor
#7 throttle-modules_0.patch9.54 KBdrumm
#2 throttle-modules.patch9.73 KBdrumm
#1 screenshot_13.png15.81 KBdrumm
screenshot_12.png37.86 KBdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new screenshot_13.png15.81 KB

Screenshot 2/2. The throttle modules page.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new throttle-modules.patch9.73 KB

This patch needs http://drupal.org/node/27804.

The throttle configuration is currently spread out on the modules page and the block configuration page. This patch moves the module throttling to a local task next to the throttle settings page. I have not worked on moving block throttling yet since I want to see what the reaction to this first part is.

If this is comitted I plan to move the block throttle checkboxes and continue improving the modules page. With less interface elements the modules page can be made even simpler that is it now.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Needs review

forgot to label it as a patch

factoryjoe’s picture

factoryjoe commented

+1 for moving throttle/performance settings to it's own page/tab

-1 for showing disabled modules; only list those that can be disabled

Issues:

  • "turning on" throttling seems counter intuitive... like, all the modules should be checked as given priority... then you DESELECT in order to take it off the priority list. I guess the current UI is opposite of most conventions... where you start with everything enabled and then take things off the list.
  • The list is not a scalable UI. If I have 60 modules (*cough cough*) I'll see the first 10-15 and ignore the rest. If you could sort by processing weight ("these modules suck up tonnes of memory! disable these first!") or by functionality, the list would be much more manageable.
  • I still think "throttle" is a terrible name. Like "taxonomy" people don't readily know what it means and avoid it like the plague. From a marketing perspective, this is bad news for Drupal since it may appears that Drupal is slow when it really just needs to have its *performance* settings tweaked.
killes@www.drop.org’s picture

killes@www.drop.org commented

-1 for adding yet another config page. teh throttle setting is fine where it is.

drumm’s picture

drumm
he/him
Location NY, US
commented

Here is an updated patch which has all of the modules checked and may be unchecked to disable them while throttled. It removes all disabled modules and required modules from the list.

The page name 'throttle' is generated directly from the module's name. Changing the module name or changing the mechanism which sets that title is out of the scope of this patch.

Ordering by processing time or functionality can be done given a decent algorithm to do that. Figuring out such an algorithm would be out of the scope of this patch too since it would need some sort of monitoring functionality as well. I think alphabetical is fine.

Does anyone have more feedback on creation of this local task page or keeping it in the modules page?

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new throttle-modules_0.patch9.54 KB
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

Doesn't apply anymore

Jaza’s picture

Jaza commented
Version: x.y.z » 6.x-dev

Patch is still relevant. Moving to 6.x-dev queue.

My $0.02:

+1 for moving the checkboxes out of the modules admin page
+1 for a local task (i.e. a tab)

catch’s picture

catch
he/him
Primary language English
commented
Version: 6.x-dev » 7.x-dev

moving to D7 queue. +1 for having all throttling in one place. Ideally if a module was throttled, any blocks it generated would be auto-throttled via javascript on such a page.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Closed (won't fix)

http://drupal.org/node/245504