Another simple patch which removes error:
Notice: Undefined index: dev_query in ***\includes\database.mysql.inc on line 80

CommentFileSizeAuthor
#6 database_inc_2.patch2.26 KBchx
#5 database_inc_1.patch2.26 KBchx
#4 database_inc_0.patch2.27 KBchx
#3 database_inc.patch2.35 KBchx
database.mysql.inc_0.patch657 byteskuba.zygmunt

Comments

dries’s picture

dries commented

variable_get is part of bootstrap.inc and therefore, it always exists. The test is probably redundant. Please test and resubmit. Thanks kuba.

chx’s picture

chx commented
Assigned: Unassigned » chx
Status: Needs review » Needs work

I always forget to post this patch.

This line was part of the bootstrap patch, so this is my work -- I do not know what got in me when I mistyped which function exists.

Why this line is necessary? Because after the bootstrap patch you can not be sure that bootstrap.inc is there when you are running a db_query.

Also there is a need to check for $GLOBALS['conf']['dev_query']. I'll post immediately.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new database_inc.patch2.35 KB

I came up with this easier to read, simpler code. I even -gasp- commented it.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new database_inc_0.patch2.27 KB

Stupid, stupid me! I forgot that we merged init.inc with bootstrap.inc

chx’s picture

chx commented
StatusFileSize
new database_inc_1.patch2.26 KB
chx’s picture

chx commented
StatusFileSize
new database_inc_2.patch2.26 KB

how many stupid errors can one make? well, tomorrow I am thirty, I am surely will be much wiser :)

Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD minus the left-overs ;).

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)