During testing uploading file I've got exception message:

Unexpected PHP error [Undefined variable: authmaps] severity [E_NOTICE] in [****\modules\user.module] line [201]

My patch changes:
if ($authmaps) => if (isset($authmaps))

I don't know if this condition is sufficient so please review (but for my testing error message disappeared )
thank you

CommentFileSizeAuthor
#2 user.module.authmap.path.txt447 bytesThomas Ilsche
user.module.authmaps.patch.txt461 byteskuba.zygmunt

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Reviewed & tested by the community

yes, this will fix the notice and won't have unwanted side effects.

This review brought to you by Patch Bingo!

Thomas Ilsche’s picture

Thomas Ilsche commented
StatusFileSize
new user.module.authmap.path.txt447 bytes

Even though the patch will probably behave correctly I would suggest the following alternative for clear style (always initialize variables).

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)