Change default setting to not collapse menus on admin/build/menu

Hrm... did you already try to click on the menu headings?

Same as http://drupal.org/node/280781, perhaps?

Well, yes, I've marked that one as duplicate. Seems like this new behavior is not yet very intuitive... ;)

"behavior"? This is really bad usability, folks: The admin/build/menu section is there to get an overview of all menu items - and you broke that core behavior. Please fix this, either by getting back to the core behavior and get rid of yours or by marking the clickable headers as collapsable panes and make the uncollapsed by default.

Well, you obviously have not dealt with large Drupal sites where it is a pain to scroll down a dozen of pages to find the menu that contains the item you actually wanted to edit.

However, setting reasonable defaults sounds sane. Please test attached patch.

Better title.

:) Sorry i did not want to insult anybody. I really love this module and it is the first module I instal on every drupal setup i work with. So thanks a lot for your work, I really appreciate it.

To handle such huge site structures, I built a module, that allows me to implement them as taxonomy trees. Unfortunately it is not ripe to post it here, but as soon as I get to that point (e.g. using menu API, performance, suability and code style tweaks as well as an automatic archiving feature), I will make it available to the masses. If your interrested, write me a message, so I can inform you when it is ready.

You can see a first version of that module in action at http://likeyou.com/ : We got a huge location tree structure there and the module is dynamically building a navigation menu of the terms that contain contents.

Thanks a lot for the patch, I am going to upgrade to 2.5 shortly.

It is a pain to scroll down on sites with a large menu, and it's quite probably a useful feature -- just needs a tweak so it's understandable what's going on, like a fieldset expansion triangle or something.

But does it belong in this module? This is the admin_menu module: it puts a menu strip along the top of the page.
One module should accomplish one task: this is in the Drupal guidelines. It's not this module's job to sanitize the menu admin page.

If you really think this way, then you could split up admin_menu into several modules. The "switch user" integration with Devel doesn't belong in here, "Disable developer modules", and additional menu items for CCK, Panels, Views not either. All of that would have to be in separate modules or implemented elsewhere.

However, admin_menu was and is being developed with one goal in mind: easing administration of Drupal. And because developing and administering Drupal sites takes 90% of my time and I need all of admin_menu's features to do it faster and better, I will continue to enhance this module to whatever it takes.
I do not want to install x modules just to kick-start my (administrative) Drupal experience. Apart from that, there are already further features waiting in the queue to be merged into admin_menu (and unsurprisingly, I have a new idea at least once a month).

Honestly, you are the first person who brought up this topic, and if you do not like it's features, feel free to remove the code parts on your site (which is not too hard).

Now, has anyone tested the patch?

Don't get me wrong, I really appreciate the extra widgets and things that are available through the admin menu. And the menu itself is a huge productivity enhancement and it's the first thing I install on any site. :)
But the danger with overloading a module of this sort with extra cool features is that it becomes the module of the tweaks *you* need, for your way of working. There's a few 'utility' modules out there that suffer from this problem quite badly. They become too personalized.
TBH, the menu admin page collapse is something I think you should submit as a patch to core. I'd certainly +1 it :)
The 'one module - one task' thing is a drupal guideline, not just my opinion.

Yes, i did just install version 2.5 with the patch applied - perfect! Although there is now no collapsing stuff at all - which may be intended. Thanks a lot!

Patch in #5 has been committed.

Attached patch changes the behavior so that menus on admin/build/menu are turned into collapsible fieldsets.

Much cleaner now by re-using collapse.js, please test attached patch.

Okay, this patch only works on the already patched version, am i right? (With the first patch you submitted?) Unfortunately it does not turn the admin/build/menu into collapsible fieldsets but admin/build/modules. And they are even collapsed by default.

Hm, strange. Even going back to the first patched version does not seam to make any difference. I don't understand what's going on. Keep you posted.

Okay, going back to 2.4 restores all collapsible stuff under admin/build/modules. So maybe your patch really affects the wrong page? If you post another patch, it would be great, if you could let me know, on which version I should apply it. Thanks a lot for your help.

All patches are against latest code in CVS - resp. the latest development snapshot, which is re-built from CVS approx. every 12 hours.

I tested the last patch (July 12, 2008 - 17:31) with 5.x-2.x-dev (2008-Jul-13). Results: No collapsable fieldsets on admin/build/menu and all collapsed on admin/build/modules.

@omo: It was your proposal to disable this new usability feature by default, which has already been committed to CVS - so, did you enable the collapsing of menus in admin_menu's settings? If you did enable the option and menus are still not rendered as fieldsets, please let me know whether the file admin_menu.menu.js exists in admin_menu's module directory after applying the patch.

@sun: Sorry for the confusion; I did not get the implementation of a new setting. After trying again (with the same versions described unter #18) everything is there as described and works flawlessly. Thanks a lot! - and sorry again, Moritz

Thanks, committed!

Great, thanks a lot. And let me know, if I can help out again.