Hi, i want to submit my modification on stock module. The stock module is no longer depend on stock API.

I add several features, like pivot point analysis, buy and selling stocks.

I need to know whether this code is acceptable or not.

Thx

CommentFileSizeAuthor
#6 stock.zip25.65 KBgehenna
stock.zip25.64 KBgehenna

Comments

xvidivx’s picture

xvidivx commented

I can't quote price wia this moudle

Plz modify it

kbahey’s picture

kbahey commented
Priority: Critical » Normal
Status: Needs review » Needs work

I think this should be a separate module under the stock project.

This way, those who need simulation can enable it without affecting the normal stock, and vice versa.

So, to do this, you have to rename your module (and all functions/hooks in it) to stock_simulator.module (and .info and .install). Also provide and I will include it with credit to you of course.

gopusa’s picture

gopusa commented

i agree.. i think its potentially very useful i would like to see what has been done so far ported to 6.x and made into a project so that the kinks can be ironed out

colorado’s picture

colorado commented

Both thumbs up!

WeRockYourWeb.com’s picture

WeRockYourWeb.com commented

Yep - a "stock portfolio" module where users can not only get stock quotes but conduct trades and manage returns has been in demand for some time.

gehenna’s picture

gehenna commented
Category: task » bug
Priority: Normal » Minor
Status: Needs work » Needs review
StatusFileSize
new stock.zip25.65 KB

actually this simulation is made for ISX(indonesia stock exchange) so it might work differently with us stocks etc.. if you want to test it properly maybe u should try indonesia stocks like "bumi.jk" , "tlkm.jk" anything ended with ".jk"

anyway i still work a chart for portfolio on it =p

derekhu’s picture

derekhu commented

Do you have a version for Drupal 6? I am very interested and would like to test it.

kbahey’s picture

kbahey commented
Category: bug » feature
Priority: Minor » Normal
Status: Needs review » Needs work

gehenna

If you want your changes to be part of the standard download from drupal.org, then please submit them as a patch. See http://drupal.org/patch for details on how to do this.

Also, it may be better to separate the simulation into its own module, since not all sites will need it. Those needing it can enable it.

Make it for Drupal 6.x as well.

ee97083’s picture

ee97083 commented

...like derekhu I'm also very interested in 6.x version for testing.

I don't know if it will help but I've converted a 5.x module up to 6.x with the help of this following web page and mentioned modules
Here it goes: http://www.webmasterworld.com/content_management/3767426.htm

Hope it helps too!! :-)

Regards

anjjriit’s picture

anjjriit commented

I have create a module for car simulation credit, but still on testing at my site, please try it, http://www.cipta-mobil.com/simulasi-kredit

alfthecat’s picture

alfthecat commented

Subscribing

SeanBannister’s picture

SeanBannister commented

sub

ah0’s picture

ah0 commented

Thanks so much for all the work.
plus++
would it possible to add Candlestick signals as well?
There is a real need for that.