Posted by Rob Loach on July 7, 2008 at 4:49pm
| Project: | Splash |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The Drupal 5 branch of Splash is kind of messed. 5.x-1.x-dev is tailored to HEAD, which looks like its made for Drupal 6. That release node should point to the DRUPAL-5 branch, which looks like it doesn't even exist. I'll put together a patch that will backport the latest Drupal 6 branch (DRUPAL-6--2) to a Drupal 5 version.
Comments
#1
I'd be willing to help maintain/create the Drupal 5 branch of Splash. The attached is a patch from DRUPAL-6--2-3 to backport it to Drupal 5 for a newly created DRUPAL-5.
#2
Fantastic, just what I was looking for!
#3
Huh... If I patch spash 6.2.3 it gives me:
"Reversed (or previously applied) patch detected!"But I continued...
The module still said 6.2.3 in the build/modules page and after enabling it, I got the following message:
* warning: Missing argument 2 for splash_help() in /home/rawvegan/public_html/sites/all/modules/splash/splash.module on line 200.* warning: Missing argument 2 for splash_help() in /home/rawvegan/public_html/sites/all/modules/splash/splash.module on line 200.
#4
This is in already! http://drupal.org/node/192759
Additional patches welcome.
#5
Automatically closed -- issue fixed for two weeks with no activity.