Warning on /admin/settings/media_mover

brunodbo - July 7, 2008 - 20:09
Project:Media Mover
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I installed Media Mover 5.x-1.x-dev on a fresh site and get the following warning when visiting /admin/settings/media_mover:

warning: Missing argument 1 for media_mover_api_config_advanced_settings_form(), called in /var/www/drupaltest/drupal-5.7/sites/all/modules/media_mover/media_mover_api.module on line 1381 and defined in /var/www/drupaltest/drupal-5.7/sites/all/modules/media_mover/media_mover_api.module on line 1643.

The page is shown ok, and I can save configuration changes.

#1

brunodbo - July 7, 2008 - 20:30
Status:active» needs review

I added the argument on line 1381. I changed:

$form['admin'][] = media_mover_api_config_advanced_settings_form();

to:

$form['admin'][] = media_mover_api_config_advanced_settings_form($form);

The error's gone now. Is it correct to do it like this?

AttachmentSize
media_mover_api.patch 599 bytes

#2

arthurf - July 9, 2008 - 21:10
Status:needs review» fixed

I did a slightly different fix on this, but thank you for the error report! Fix is in CVS, will get committed to 1-0-alpha2

#3

Anonymous (not verified) - July 31, 2008 - 04:47
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.