Postgres support
HorsePunchKid - July 7, 2008 - 20:10
| Project: | Activity Stream |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | akalsey |
| Status: | closed |
Description
Here's a patch that offers Postgres support. I've tested install and uninstall against Postgres 8.
I also had to change the call to update_sql to just db_query; I'm not quite sure why, but I was getting an undefined function error upon uninstallation.
| Attachment | Size |
|---|---|
| activitystream_5.x-1.0_postgres_0.patch | 2.54 KB |
#1
This patch fixes several problematic queries. It seems to basically be working now, though I've only tested the Last.fm and generic feed types.
#2
Have you also tested on MySQL to ensure that your patch doesn't break MySQL support?
#3
Patch updated against 5.x-1.1 and tested against both Postgres and MySQL. Seems to be working fine. The main thing here is not to use double quotes inside SQL queries. It's nonstandard, and Postgres will not accept them.
I haven't tested the various sub-modules, but this patch doesn't touch them, either.
#4
Fixed another Postgres error during cron. Retested against PG and MySQL, including running cron this time.
#5
Commited.
#6
in 1.2
#7
A couple issues:
defined correctly for PostgreSQL
update #2 is not in the table definition for either MySQL or PostgreSQL
as the update SQL has MySQL-specific SQL.
Patch addresses these issues
#8
If someone else who uses postgres can review this patch, I'll commit.
That's because that index is useless. It snuck in the backdoor through an unrelated patch.
#9
Closing. d6 schemas should be working for Postgres and D5 has been marked as end of life