I've added code which prevents user from submiting 2 roles with the same name.

CommentFileSizeAuthor
#2 unique.roles.patch_0.txt1.57 KBkuba.zygmunt
unique.roles.patch.txt1.61 KBkuba.zygmunt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

breyten’s picture

breyten CreditAttribution: breyten commented
Status: Needs review » Needs work

+1 on feature (I think it's always useful to have these kind of checks -- will probably save us bug reports in the future;), but -1 on the patch. It's not necessary to call db_fetch_object to just get a role id. You can change it to this:
$rid = db_result(db_query("SELECT rid FROM {role} WHERE name = '%s'", $edit['name']);
and then simply
if ($rid) {
.
.
.

kuba.zygmunt’s picture

kuba.zygmunt CreditAttribution: kuba.zygmunt commented
Status: Needs work » Needs review
FileSize
unique.roles.patch_0.txt1.57 KB

Ok, I've changed code. I hope that this code will be good enough. ;)

Uwe Hermann’s picture

Uwe Hermann CreditAttribution: Uwe Hermann commented
Status: Needs review » Reviewed & tested by the community

+1. Patch applies and works as expected.

Dries’s picture

Dries CreditAttribution: Dries commented

Any reason you can't use the same code twice? I like the first approach better; avoids an object being created.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work
Jaza’s picture

Jaza CreditAttribution: Jaza commented
Version: x.y.z » 4.7.x-dev
Status: Needs work » Closed (fixed)

Patch no longer needed: uniqueness of role names is enforced in HEAD in the user_admin_role_validate() function.