Code review #1

Some notes from the first review of 6--2.

General

-- Please use braces for all logic statements in accordance with Drupal code standards.

  if {
  }

See lines 79, 81, 101. Coder module can help here.
See also lines 270-274 for improperly nested logic statements.

-- We really can't use submodules titles like 'jpeg' or even 'word_xml' simply
because we don't want to hog the namespace.
-- JPEG module is only a tester, but it should really be a generic image handler, since
JPEG, GIF, PNG can be treated identically. Call it docapi_image() and you can do some good
mimetype checking / handling on the different image types.
-- Be extra careful that you hook names don't step on other hooks.

docapi_menu()

-- #title and #description no longer use t().

docapi_perm()

-- module needs its own configuration permission instead of 'administer site configuration'
-- permissions should be all lowercase.

docapi_cron()

-- Is cron the best place to do this? Why not just call this at the configuration page.
-- Or -- better -- require modules that use the API to use hook_enable()

  function myplugin_enable() {
    docapi_find_plugins();
  }

docapi_find_plugins()

-- Does this function also clear "dead" plugins from the {docapi_plugins} table?
Or, you just require that modules clear themselves on hook_disable().