After rapid development Flv mediaplayer is due for a bit of cleanup and minor refactoring. There are also some loose ends, particularly with the views implementation and recommendations.

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

Applied fixes and refinements including:

* Various views-related fixes
- Move rendering to flvmediaplayer from flvmediaplayer_views.
- Use format_xml_elements().
- Feed view name to rendering.
- Append node ID as arg to recommendations view urls. This enables the construction of views with node ID arguments so that recommendations can be node-specific.
* Fix issues with node-specific configs
- Ensure data are saved and loaded.
- Use a node type's registered configuration as default if available.
* Remove flvmediaplayer_extend(), use module_invoke_all() instead.
* Load $node->flvmediaplayer_config in nodeapi's 'load' op.
* Remove 'nid' and 'node' from config array.
* Pass node in flvmediaplayer_extend_fire(). This permits e.g. the appending of node IDs to view paths.
* Fix hook_menu() implementation (previously didn't use $may_cache test).
* Various minor code style tweaks.

NOTE: sites will need to run an update to refresh menus.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.