This themeable function is not used in core. It is used once in contrib. The author of that module is okay with removing it.

CommentFileSizeAuthor
#4 pager.inc.diff1.43 KBdrumm

Comments

jeremy’s picture

The idea is to make it available for use in themes, modules, etc, to design custom pagers. Why exactly do you need to remove it?

moshe weitzman’s picture

Status: Reviewed & tested by the community » Needs review

i agree with jeremy. can't we find more meaningful patches than ones which strip themeability. I can't evaluate the patch because I don't see a file. maybe thats a bug, or drumm just forgot.

not everyone uses our google ripoff pager. i have customized this in the past for clients. you can't look at contributed themes and then conclude that a theme function is not used.

Bèr Kessels’s picture

another -1. This theme function was added to allow better themeing of teh pager. Before this function we could only go for the standard pager, now we can theme it much nicer.

drumm’s picture

StatusFileSize
new1.43 KB

Not sure what happened with the patch file.

This is code that isn't used anywhere but is loaded for every page view anyway. It could live in contrib or in some documentation instead.

dries’s picture

I'm with Neil here. This function is not called anywhere, hence it is dead code -- at least for core and contrib. If you need this function, you can still implement it elsewhere (eg. in your theme).

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

ok, this patch makes sense now. this is simply unused code.

dries’s picture

Committed to HEAD. Thanks.

jeremy’s picture

Prior to comitting this patch we had a couple extra lines of code in pager.inc, and a completely alternative possibililty for displaying a pager. For negligible memory, and negligible maintenance cost we had choices for custom themes and modules.

Now there is only one type of pager available with Drupal.

Sure, someone could write this fuction themselves, but realistically it's just complex enough that very would ever bother to do so.

I'm disappointed to see this code removed, as I see no gain, only loss.

drumm’s picture

Project: Drupal core » Documentation
Component: base system » Developer Guide

Should I put a copy of the code in tricks or somewhere in the handbook?

dries’s picture

@drumm: good idea

drumm’s picture

Status: Reviewed & tested by the community » Closed (fixed)

It is now in contrib/tricks.