The type column of the node table is VARCHAR(16).

CCK prepends 'content-' onto its content types, leaving only 8 chars for a descriptive "short name" of the content type. For example, "content-shoe-size" already exceeds the limit.

This patch changes the column width to 32 characters.

CommentFileSizeAuthor
type32chars.diff2.48 KBjvandyk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

Status: Needs review » Reviewed & tested by the community

I read the code and looks fine with me. jvandyk says the pgsql way is necessary unless we want to support only 8.0

Bèr Kessels’s picture

I am no SQL guru, but AFAIK this will greatly affect the memory usage of mysql. At least that is why i refraind from this solution and renamed node_aggregator to naggregator when that module bumbed into this 8 char limit.

killes@www.drop.org’s picture

Ber: I'd really like to have some proof or even evidence for this claim...

I don't think it is a problem.

Bèr Kessels’s picture

I meant it as a question, because I am simply not sure.
http://dev.mysql.com/doc/mysql/en/data-size.html states that it really affects your speed and size when you use bigger fields. But I am simply not sure if this is completely true in this case. As sated: I am no sql guru. But i would like one to comment on this issue!

Steven’s picture

True, but we use varchar() fields, not char() fields. Their length is their contents + 1 byte for size. In the node table, I think the actual body contents pretty much make the other columns irrelevant as far as actual used size goes.

Steven’s picture

Status: Reviewed & tested by the community » Fixed

Commited to head.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)