Drupal 6 port?

subscribing

subscribing

Here is a patch from the latest 5.x dev Version

and a codestyle patch, which uses the port patch

TODO: Schemeapi in .install file
TODO: .admin.inc .pages.inc

review it please, thanks!

Subscribing - thank you.

Does anyone have any feedback regarding the patches for this module for Drupal 6 usage?

Hi.
Did a quick review of port_6_2.patch and from my point of view it looks good.

 Stefan

Patch needs more review...

Firstly, thanks a lot for your work to port his module to D6!

I've lost count as to how many people consider this module essential for their Drupal installations. Without a fuzzy search and/or porter stemmer module installed, searching a site can be a very frustrating experience.

I never used Fuzzy Search in D5 - but in comparison to the standard search in D6 is it retrieving many more relevant nodes from the input I give it (when I enter partial words, misspellings, etc)

The only exception I have noted is as follows:

D6 Core Search Module:
When I search for a word (like "Bar Fandango"), it retrieves the relevant node for "Bar Fandango" and any nodes that are related to it (ie. that has a CCK nodereference pointing to the "Bar Fandango" node - such as images and films)

Fuzzy Search (patched for D6) Module:
It only retrieves the node for "Bar Fandango" and none of the related (via CCK nodereference) nodes.

---

I am guessing that because nodereference is now part of CCK for D6, it is being indexed automatically and accessed by the core Drupal 6 Search module.

Perhaps Fuzzy Search (patched for D6) is not using these nodereference indexes properly for finding relevant results?

Andrew

When I reset my Apache server (Apache/2.2.11 (Win32) mod_ssl/2.2.11 OpenSSL/0.9.8i PHP/5.2.8), I get the following deprecated warning on the first page load, due to the Fuzzy Search module:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of module_invoke_all(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in \sites\all\modules\fuzzysearch\fuzzysearch.module on line 342

Any more progress/testing for a D6 port?

i just ported the module to d6, test it out, perhaps the maintainer will see this issue.

It only retrieves the node for "Bar Fandango" and none of the related (via CCK nodereference) nodes.

This is currently not part of the module so this shouldn't be part of the update patch

here is a updated patch which fixes

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of module_invoke_all(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in \sites\all\modules\fuzzysearch\fuzzysearch.module on line 342

Edit: I am an idiot

Just used the patch to get it working on D6.12

Couldn't work out why the search results were no different. I was going through the module code to see if I had patched this correctly as I am really new to all this stuff and I noticed.

/**
* Theme the output of the search block
*/
function theme_fuzzysearch_box_form($form)

Groan.... I was trying to use the normal search, didn't realize that this functioned through a module block.
I did some test searches , this performs really well. The results are far better than te default results I was getting.

There are no log errors after updating or performing searches
All seems good we need an official update for this.

Is there any way of making this the default search for a drupal site ?

I think I found a installer issue. My install is configured to prefix table names, but the installer created "search_index_queue" and "search_fuzzy_index" without the prefix. The module itself seems to work, i.e. it queries the correct and prefixed table names.

Judging from the code (I'm fairly new to Drupal) are the CREATE statements just missing curly braces?

subscribing

I didn't mention earlier but the compiled/patched version is available on my sites blog if someone needs to test it for Drupal 6 - see my profile.

I would contribute something more to this as it is a good module but I am not a php coder. Hoping for an official D6 version

It would be confusing if there is <COREVERSION>-6.0, anyways the casual user would think it is the sixth version of the module (where <COREVERSION> is the Drupal core version).

I've made a 6.x-compatible version using the deadwood project. If there is any flaw(s), I will certainly make fixes to it.

I'm going to test Frank's and report occuring bugs. I hope there wont be many :)

@frank0987
thx for your work.
I've tested your version on 6.12 with the following results:

- search shows up, but no hits are shown
- fuzzy search's settings page is not shown

so no chance to reset it's search index, if that's what's needed.

The version I patched earlier is 6.1++ compatible I have been using it for a few months. The only thing that needs changing is the version number etc. I didn't post it earlier as I am not a PHP coder and I did modify it to fit more closely with my sites layout. I think you need to re- index the site for it to start working correctly , that will take a few cron runs.

If you are interested you can find the page it is on below but read the last part of the blog page it will tell you what has been changed.
It needs to be placed in a block too.

(basically the text format of the results so it wont show a teaser.)

http://www.notascoolasitseems.com/blog/yeee-haaaa-it-works

Hope this is helpful

subscribing

subscribing

installed module from #22. It installs fine but doesn't do anything to the search. I've reindexed everything but it still isn't matching partial words or spelling mistakes...

Anything else I need to do to get this working?

Yes.

Its a block module.

It doesn't do anything to the default search . You need to create the block and make it visible to enable it . I would have replied sooner but I haven't been on the drupal site.
If you have any problems you can e-mail me from the site or leave a comment at that page.

Good luck

subscribing

@dereine and LuisCypher

The installer isn't coded correctly;

# line 7
      db_query("CREATE TABLE {search_index_queue} (
# line 8
      db_query("CREATE TABLE {search_fuzzy_index} (

place table names between {} otherwhise table prefixing doesn't work....

Cheers

I modified those two lines.
Anyone want to test it ?

The results of the search are measured by "completeness" and "score". At the moment the results are returned to the user in the order of completeness I think - the other measurement seems to be more useful and accurate for returning the results.

Anyone know how to change it ?

Subscribing. Shouldn't this be in the core?

subscribing

I have a port for D6 that I will be adding soon.

OK, the D6 version is up. Please open new issues and do not use this one any more.

Enjoy!

Brilliant! Thank you, I'll be trying it out ASAP!

Cheers

I added a block to the module that returns nodes base on a query in the url. I'm using this in a similar content block on a new site. It has the potential to be slow as the index table grows, so the block probably isn't recommended on every page. I'm using it on a node/add page to suggest existing content that might keep the user from creating a new node.
Feldene

Not sure if there's a new question, but this issue is closed, and the feature exists in D6. Please open a new issue if there's a question. Thanks.