I'm using Timeline in a family history context with mainly historical dates from about the year 1690 to the present. Somewhile back I noticed that the initial date focus 'First event in Timeline' which in my case used to provide an historical date had reverted back to a Unix date of 1970. I'm not a coder but looking at the code it appears that around line 567 of the Timeline module the function _timeline_load_extended_dates checks for adodb-time.inc.php in the Date module. Date module hasn't used the historical date plugin for quite some time, but if I drop adodb-time.inc.php into modules/date/date folder then the initial date focus does at least pick an historical date though it still does not use the 'First event in Timeline'.

My Timeline views are cloned from the provided Timeline example and work OK so I'm not sure if I am missing something or if the code needs ammending.

This is a great module by the way, thanks for the hard work, much appreciated.

CommentFileSizeAuthor
#11 date2_d6_timeline.module.patch2.45 KBcglusky
#8 timeline.module.patch2.71 KBkarens

Comments

jmiccolis’s picture

jmiccolis commented

Can you let me know what version of the date module you're using.

Thanks!

jupiterchild’s picture

jupiterchild commented

Latest Drupal 5 release of the Date module 5.x-2.x-dev (2008/07/08).

BTW a couple of days ago I had a dialogue with KarenS the current developer of the Date module see http://drupal.org/node/277420 re: a problem with some changes to the Date module date filter in Views which caused a problem with timelines. This is now resolved though you may wish to check the examples included with the Timeline module.

jmiccolis’s picture

jmiccolis commented
Title: Initial date focus » Support Date 2
Assigned: Unassigned » jmiccolis
Category: support » task

Currently the Date module support is for the 1.x version. But you're right, it's about time to update this for Date 2 support.

karens’s picture

karens commented

Subscribing, I need to get back here and help get this done. Just marking it for now so it shows up in my issues.

I use the timeline module myself, so I need this too :)

bomarmonk’s picture

bomarmonk commented

Subscribe

jmiccolis’s picture

jmiccolis commented
Version: 5.x-1.0 » master
Category: task » feature

Changing version to head. I don't have plans to add date 2 support to Timeline's Drupal 5 branch (but I always accept patches!). But it will certainly be in the Drupal 6 version.

karens’s picture

karens commented

Related issue at #318262: Initial Date Focus not working properly was marked as a duplicate.

karens’s picture

karens commented
Version: master » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new timeline.module.patch2.71 KB

Here's a patch to get this working correctly with Date version 2. This is a patch for the D5 version, but the same code should work fine in D6. I don't have the D6 version installed to test it, but version 2 of the Date API works the same in D5 and D6 and the same functions are used.

This will eliminate support for the older Date version, but that version is no longer recommended, so that should be fine.

mroswell’s picture

mroswell commented
Status: Needs review » Reviewed & tested by the community

Works for me. Thanks Karen.

(http://drupal.org/node/318262 re-opened, as I don't think it's connected to this patch.)

jmiccolis’s picture

jmiccolis commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to the DRUPAL-5 branch. Thank you Karen!

Marking as 'to be ported'.

cglusky’s picture

cglusky commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new date2_d6_timeline.module.patch2.45 KB

here's a quick cut and paste against latest d6 dev - [EDIT] I have now installed this module with Karen's most excellent patch and it seems to work a treat. i am not sure if this patch has cleared up some other issues as well (or i just didn't know what i was doing - very possible), but i no longer need to create a cck date field to get the nodes to display on the timeline. e.g. i was able to use node creation date, whereas before that did not seem to work. i have a working example up here:

http://ic.metanomy.org/?q=timeline

but that might be a bad example as i also worked on getting feedapi item's timestamp to work as well; i'll create another issue with patch for that.

thanks alex, jeff, arto and karen for all the great work!

R,
Coby

jmiccolis’s picture

jmiccolis commented
Status: Needs review » Fixed

I've given the patch some light testing and committed it.

Thanks everybody.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.