Coder module is showing lots of errors. Maybe before next release we can split the files between us (us as all the members that want to participate) and fix all the coding style issues.

CommentFileSizeAuthor
#9 workflow_ng_20080714_coder.patch11.42 KBintchanter
#7 workflow_ng.module_style_1.patch41.42 KBamitaibu
#4 workflow_ng_20080710_coder.patch36.68 KBintchanter

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented

that sounds great. Doesn't the code module produce ready to use diffs?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

No diffs, although many mistakes can probably be fixed with some regex replace.

intchanter’s picture

intchanter commented
Assigned: Unassigned » intchanter

I should be able to handle this and provide a patch later today unless there are any objections.

intchanter’s picture

intchanter commented
Status: Active » Needs review
StatusFileSize
new workflow_ng_20080710_coder.patch36.68 KB

Here's the patch for the DRUPAL-5--2 branch.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Active

thanks committed!

Should we go ahead with the extension modules?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

@intchanter,
good job - are you using a script for this - can you share it?

@fago,
There are still style issues in the comments (e.g. adding a dot in the end, syntax of @param, etc'). I'll give it a stab.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new workflow_ng.module_style_1.patch41.42 KB

Fixing comments in workflow_ng.module - is there a way to use a script for this? Its pretty annoying doing it manually :P.

intchanter’s picture

intchanter commented

I did it manually, but it wasn't too bad with vim, hence the speed of the original patch. Coder claimed it passed everything with minor warnings enabled here. What settings are you using to see issues in some of the comments so I can watch for that in the future?

One thing that did help speed it up was using vim's regex replace syntax and the fact that it keeps :command history, so stripping all the trailing whitespace was <load a file>:<up><up><enter><up><up><enter> for each file.

intchanter’s picture

intchanter commented
StatusFileSize
new workflow_ng_20080714_coder.patch11.42 KB

Here's an updated patch against current DRUPAL-5--2 that takes care of the rest of the modules (I think). It covers cclinks, states, _log, and _ui. No additional issues found with minor warnings enabled.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

#7 is still CNR as well.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

thanks. I've committed #7.

@#9: I wasn't able to apply it. Please be sure to create patches in uniform diff format.