Incorrect URL in default mail message

sethcohn - July 9, 2008 - 14:25
Project:Webform
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

theme_webform_mail_message:

<?php
$message
.= t("The results of this submission may be viewed at:") ."\n";
$message .= url('node/'. $node->nid, "sid=". $sid, NULL, TRUE);
?>

This yields a url of the form /node/###?sid=###
which is incorrect (and blank), the actual URL to view the submission is:
/node/###/submission/###

Easy enough to temporarily fix via custom theming (copy theme_webform_mail_message to your theme's template.php, rename to yourthemename_webform_mail_message, and make the below change)

The default code in the module should be corrected to:

<?php
$message
.= t("The results of this submission may be viewed at:") ."\n";
$message .= url('node/'. $node->nid. "/submission/". $sid, NULL, NULL, TRUE);
?>

#1

quicksketch - July 12, 2008 - 23:03
Status:patch (code needs review)» fixed

Thanks, I corrected this URL. The link present is one that worked fine in the 2.0 version I think, and I'd meant to keep supporting the old URL for a few versions to ease transition. However, looks like I broke the old URL earlier than I intended.

So, I just update the URL. It'll be fixed in the next version, which I intend to make shortly.

#2

Anonymous (not verified) - July 31, 2008 - 04:47
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.