The test suite packaged with Organic Groups isn't compatible with Drupal 6 and doesn't pass all of the tests offered. I'm posting an initial patch, that makes simple changes to function calls so that it can run under Drupal 6. I'll try to work on adding more unit tests and passing the rest of them.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | og_wiki.test | 5.48 KB | tmcw |
| #5 | tests_to_good.patch | 16.2 KB | tmcw |
| #3 | tests_to_clean.patch | 11.89 KB | tmcw |
| #2 | patches_to_pass.patch | 12.63 KB | tmcw |
| patches_to_six.patch | 8.54 KB | tmcw |
Comments
Comment #1
moshe weitzman commentedcommitted. please do keep working here. each test is a huge help to me and to the project.
Comment #2
tmcw commentedA patchset to get all of the included tests to work. It's a work in progress: some of the tests are relaxed slightly because parts of SimpleTest (especially assertWantedRaw) are not cooperating. I'll continue working on this till it's at a good state.
Comment #3
tmcw commentedThis avoids some of the quirks of the last patch. A bug in SimpleTest is preventing this from passing normally: I've posted a patch on their queue.
Comment #4
tmcw commentedThat patch could use a little bit of cleaning. After that's finished, do you think that this level of test coverage is sufficient for the release? More tests, or more cases of these? Or are there any other outstanding tasks which would be useful?
Comment #5
tmcw commentedHere's a good version of this patch, lots of things standardized, etc. I've also added og_wiki.test, which tests the wiki permissions on nodes.
Comment #6
moshe weitzman commentedI have committed this fine patch. Many thanks.
We have a few failures in the membership test due to my earlier commit which changed a bunch of strings for translation. Could you please submit a patch which fixes these? Of course more tests are also much appreciated. Great work.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.