A bad thing have happened a while ago: somebody asked how to put a flagging link somewhere on the page, and in response I published some code to use (a _flag_create_link() function). My intention was one: to get feedback on the code so we know it's ok to provide this utility function in the next release. The problem is that people are going to use the code I gave, and that code uses our API, and the details of that API are going to change. Which means that sites of users using this code are going to break quite soon.

So I think we should provide flag_create_link() right away, in 'dev', and instruct anyone asking "how to put a link somewhere" to upgrade to it. I actually think we should name this function '_flag_create_link', with a leading underscore, so that we have the freedom to devise a more "perfect" interface in the (near) future.

Comments

quicksketch’s picture

quicksketch
he/him
commented

I think flag_create_link() looks great as you originally wrote it. I'd suggest without the leading underscore, since users will call the function if it exists regardless of whether the function is "private" or not. Especially, since if it's "private", we wouldn't need to provide it at all. :)

mooffie’s picture

mooffie commented
Title: Provide flag_create_link() » Provide _flag_create_link(), for easily printing flag links in templates
Status: Active » Fixed

Fixed.
http://drupal.org/cvs?commit=126569
http://drupal.org/cvs?commit=126570

I did put an underscore there, for the time being. I prefer we wait a bit before we finalize it.

I'll also update the related issue with instructions to use this new 'dev'.

mooffie’s picture

mooffie commented

I'll also update the related issue with instructions to use this new 'dev'.

(I'll have to wait till D.O. packages this 'dev'. I understand that it takes several hours.)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.