Update to Drupal 5.8 breaks Tabbed Block
Balefire - July 10, 2008 - 10:02
| Project: | Tabbed Block |
| Version: | 5.x-1.2 |
| Component: | User interface |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
After an upgrade to 5.8, Tabbed Block stops showing tabs and acts as if the browser does not support JavaScript. I have tried the following:
1. Upgrade to 5.8 - TB stops working
2. Restored backup of 5.7 - TB works
3. Applied Security Patch to 5.7 - TB works
3. Returned to 5.8 & applied JQuery Update 5x-1.0 - TB not working
4. Applied JQuery Update 5x-2.0-rc1 - TB not working
5. Restored 5.7 backup, applied Security Patch and JQuery 5x-2.0-rc1 - TB works
Firebug offers no warnings or errors when viewing 5.8 with Tabbed Block not functioning. Not sure what else to try or what other information you need. While a security patched 5.7 is fine for now, any help/advice to get Tabbed Block working with 5.8 would be highly appreciated.
#1
had you tried 1.3?
i know that is not a release. but just give a try.
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/tabbed_bloc...
and i tested 1.2 on a fresh D5.8,
works.
further invest needed. "stop working" means it is not displayed as tabs?
are the content there?
if so, i will predict it as a js script error..
#2
Thanks for the reply.
I checked the rendered page source for the 5.7 & 5.8 versions - in 5.7 the tabbed_block.js is being loaded via $scripts, but not in 5.8. I have checked, rechecked and checked again file permissions all the way from the webroot down. The files are in the same location in both versions and have the same permissions. If I manually add the link to tabbed_block.js in my page.tpl.php for 5.8 then it works! I will keep on this and try to figure out exactly what is happening and report back when I find out what I'm doing wrong.
#3
I believe there is a core bug in 5.8 that prevents the loading of JS and CSS files added by drupal in block.module. This has cause some other modules not to work as well. To fix this revert your modules/block.module back to Drupal version 5.7 until a fix is out for this.
I hope that may help as i have not tried it with this module but i believe the same core bug is responsible for this.
See: http://drupal.org/node/232037 and http://drupal.org/node/281026
thanks,
#4
I was coming back to report on some experimenting I have done.
I narrowed it down to the
<?phpdrupal_add_js( $path."/tabbed_block.js" );
?>
line not being called in function tabbed_block_block. As a "I wonder what's happens if I do this", I added
<?phpdrupal_add_js('sites/all/modules/tabbed_block/tabbed_block.js');
?>
to lightbox2.module just below where it's drupal_add_js is called and tabbed_blocks.js was loaded! Unfortunately that's as far as my limited knowledge can take me. I hope this helps with working out what/where/why & how to fix.
As previously mentioned a security patched 5.7 works as intended and I'll keep an eye on those two threads. I'm not a great programmer by any reckoning and have no experience of patching core code, but will help out as and if I can. After reading those threads I have since found that several other features are not working either so your excellent block is not alone :)
#5
Thank you for those in depth investigation.
and it is core bug in 5.8. revert 5.7 block.module will works. patches may comes out from: http://drupal.org/node/281042