This will avoid issues such as the 'headers already sent' issue you have fixed in the last commit.

It's also part of the Drupal coding guidelines. Likely applying Coder module will catch such things and possibly save you a bunch of work.

Fantastic progress, though - great work!

Djun

Comments

anshuprateek’s picture

anshuprateek commented
Assigned: Unassigned » anshuprateek

yups, true! Now that you mention it yes! Will do so (remove the closing tags) in my next commit! Thanks for the review!

anshuprateek’s picture

anshuprateek commented
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.