Hi,

It looks like the module enters an infinite loop when unpublishing a spam comment. Here are the steps to reproduce:

  1. Enable the duplicate filter.
  2. Set the "posting action" option to "allow spam content to be published, automatically unpublish and notify user". (I'm using this option because it looks like the option "place into review queue" is not implemented yet, or this is what I managed to gather after quickly skimming over the code. Am I wrong in this assumption?)
  3. Post the same comment twice as an anonymous user.

    4. What happens: the first comment goes through fine. When you post the second comment, the website hangs and never sends a response until it times out. If you check the spam logs, you will find hundreds of pages of log entries involving the same comment.

    I suspect that this is caused by the way spam_unpublish is implemented. Maybe it's calling itself and getting stuck in infinite recursion? I haven't had the chance to take a deeper look yet.

    Thanks.

Comments

jeremy’s picture

jeremy commented

Thanks for the bug report. I remember having a problem with this many months back, but thought it was fixed. Either it's been reintroduced, or it's a configuration thing. Either way, I'll track it down when I've got time.

You are correct, the review queue has not yet been implemented. This is the last major issue before the module will enter beta status.

jeremy’s picture

jeremy commented

I followed these steps, but was unable to get into an infinite loop. Are you using the latest development version of the module, or an old one?

Ayman’s picture

Ayman commented

I'm pretty sure I was using the latest dev version. I tried to reproduce the bug again but couldn't. Perhaps it was because of another module I had, or a particular setting. I no longer have the database I was using back when the problem happened.

Feel free to close this bug. I will open it again with more details if it happens again.

jeremy’s picture

jeremy commented
Status: Active » Fixed

Please re-open if you figure out how to duplicate the bug. Until then, I'll assume it's fixed. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.