Avatars do not validate
IceCreamYou - July 11, 2008 - 04:19
| Project: | Blogger |
| Version: | 5.x-1.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
On the Blogger block when Avatars are enabled, they are printed without alt tags which are necessary to validate XHTML 1.0 Strict.
For reference, the relevant code.
if (($blogger_avatar) AND ($data->picture<>"")) {
$blogger_img = base_path().$data->picture;
$showpict = "<img src='$blogger_img' "
.($blogger_avatar_width<>0 ? " width=$blogger_avatar_width " : " ")
.($blogger_avatar_height<>0 ? " height=$blogger_avatar_height " : " ")
."></>";
} else {
$showpict = "";
}
$block_content .= '<tr class="'.(($i % 2) ? 'odd' : 'even') .'">';
if ($blogger_avatar) {
$block_content .= '<td '.($blogger_avatar_width<>0 ? " width=$blogger_avatar_width " : " ").'>'.$showpict.'</td>';
}
$block_content .= '<td>'. l($showdata, "blog/$data->uid").'</td>';
$block_content .= '</tr>';
//$block_content = 'ssadsdsd 123';
}
$block_content .= '</table>';
$block_content .= '</div>';
#1
Also, just noticed the img tag is closed incorrectly.
$showpict = "<img src='$blogger_img' ".($blogger_avatar_width<>0 ? " width=$blogger_avatar_width " : " ")
.($blogger_avatar_height<>0 ? " height=$blogger_avatar_height " : " ")
."></>";
The tag outputs <img ... > < / >
#2
Also got this...
<div class="center-wrapper"><div class="panel-panel panel-col-first">
<div class="inside"><div class="panel-pane">
<div class="content"><div class="panel-display panel-2col clear-block" id='mini-panel-minipaneljournaling'>
<div class="panel-panel panel-col-first">
<div class="inside"><div class="panel-pane">
<h2 class="title">Journalists</h2>
<div class="content"><div id="blogger"><table><tr class="odd"><td width=20 ><img src='/files/userpictures/picture-1.jpg' width=20 height=20 ></></td><td><a href="/blog/1">ADMIN (1)</a></td></tr></table></div><div class="more-link"><a href="/blogger/list" title="More bloggers...">more</a></div></div>
Does not validate!