I cannot deselect Web Images boxes. The changes aren't applied on node/*/edit/components/*.

Another bug, on bottom of submission emails from pages where the submission path URL is modified (through Path module) I got:

mycustompath/send-cv?sid=3

Where submission ID is 3, but that page is empty. The right one is:

node/54/submission/3

CommentFileSizeAuthor
#5 webform-file-filter-deselect.patch632 byteslongwave
#2 webform_cannot_deseclect_webimages.png14.05 KBchirale

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Postponed (maintainer needs more info)

The submission link was fixed in the 2.1.2 version. I'm not sure what you mean in your first request concerning "Web Images boxes", could you try out the 2.1.2 version and see if that problem still exists?

chirale’s picture

chirale commented
StatusFileSize
new webform_cannot_deseclect_webimages.png14.05 KB

Thanks for the reply. Submission link now is ok. Problem deselecting Web Images on "Upload Filtering" (node/*/edit/components/*) on edit Webform page persists (screenshot attached).

Just try to deselect all gif, jpg and png types and save. Changes seems aren't applied for this types.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Cannot deselect Web Images, email submission link wrong » Cannot deselect all Web Images types in file component
Version: 5.x-2.1.1 » 5.x-2.1.3

I'm also seeing this in 5.x-2.1.3. I only want to accept document file types, but deselecting all three Web Images checkboxes (gif, jpeg, png) has no effect - the checkboxes are reset to the previous settings.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed (maintainer needs more info) » Active

Actually, this applies to all the file type groups. Once you have selected any file type for a particular group, attempting to deselect all items in that group is ignored and resets the group to the previous settings.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new webform-file-filter-deselect.patch632 bytes

I think I've tracked this down to the way the checkboxes are processed in _webform_edit_file_filtering_validate(). The attached patch appears to fix this issue for me.

chirale’s picture

chirale commented

Thanks longwave, I've tried to deselect jpeg, gif and png to an existing webform element without any effect (same issue) on 5.x-2.1.3.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks longwave! To my credit, it looks like a bug in Drupal 5's handling of checkboxes ;)

The checkboxes worked fine in Drupal 6 without the patch, but for consistency I applied it to both version. Thanks for the patch!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.