two active menu local tasks

I think this is l10n client's issue

I don't know what happens with that menu, but I see the two tabs causing trouble are l10n's. Maybe the issue happens when one more tab is added there (language icons) but I'm just adding a 'non default local task'...

Gabor?

Localization client just adds the "Language negotiation" default tab and the "Localization sharing" non-default tab:

  // Direct copy of the Configure tab from locale module to                                                                
  // make space for the "Localization sharing" tab below.                                                                  
  $items['admin/settings/language/configure/language'] = array(                                                            
    'title' => 'Language negotiation',                                                                                     
    'page callback' => 'locale_inc_callback',                                                                              
    'page arguments' => array('drupal_get_form', 'locale_languages_configure_form'),                                       
    'access arguments' => array('administer languages'),                                                                   
    'weight' => -10,                                                                                                       
    'type' => MENU_DEFAULT_LOCAL_TASK,                                                                                     
  );                                                                                                                       
  $items['admin/settings/language/configure/l10n_client'] = array(                                                         
    'title' => 'Localization sharing',                                                                                     
    'page callback' => 'drupal_get_form',                                                                                  
    'page arguments' => array('l10n_client_settings_form'),                                                                
    'access arguments' => array('administer languages'),                                                                   
    'weight' => 5,                                                                                                         
    'type' => MENU_LOCAL_TASK,                                                                                             
  );                                                

Looks like i18n is also adding a defualt tab there. I have no idea ATM on how could we avoid multiple contribs putting in default tabs there. I also think that l10n_client is adding a more specific default tab title, which is better to use instead of just plain "Configure". I'd try using the same default tab code in Language icons, and see what happens.

Same here. I'm with Garbor - we should use the 'Language negotiation' tab title.

Patch attached copies 1:1 the menu item from l10n_client. We might need a menu refresh in .install for people upgrading from older versions...

Could somebody please test that the patch works as expected? Thank you.

I think this was caused by a bug in i18n module (menu_alter) already fixed so possibly no need for any patch here.

Jose: No, this patch needs to go in...

@hass,

Yes, you're right, I had read the thread too quickly...

I've tried it and it works.

Thanks for testing, Jose!

I'll commit this once I get back to my private development machine. (And per #4, I'll add a menu_rebuild() to a hook_update_600N, just to play it safe.)

The menu refresh is not really required... all people should run update.php... on every module update.

@ hass: Alright. Thank you. :)

I've committed the patch to 6.x-2.x and 6.x-1.x and once I've committed the flag icons waiting in the queue, I'll make a 6.x-1.1 release.

Thanks for the help and inputs everyone! :)