Not working with Webforms module

I just posted this issue in the Webform support area also for visibility and perhaps a faster answer depending on who might have the answer. Here's the link to the webform support issue: http://drupal.org/node/281604

There are 2 messages, but I don't know what they mean, or what I should change. Here they are. Note that I have changed the domain and email address for security.

#1
Type: smtp
Message: Error sending e-mail from "www.domain.com" to user@domain.com: Language string failed to load: from_failed"www.domain.com"
Severity: error

#2
Type: mail
Message: Error sending e-mail (from "www.domain.com" to user@domain.com).
Severity: error

Okay, I found the answer to this particular error. But it still doesn't work. There's a new error now.

Solution to previous error: Language file not found in class.phpmailer.php. Once I forced PHPMailer to find the en language file, that error went away, but the form still wouldn't send. The new error is:

Type: smtp
Message: Error sending e-mail from "Form Title"  to user@domain.com: The following From address failed: "Form Title" 
Severity: error

I think this has to do with an inconsistency between what webforms is providing as a FROM, and what SMTP exects to see as a FROM in the last parameter of drupal_mail() function... still working to resolve... but its getting late and I need sleep. If anyone else wants to take a look, it appears that in my case, the webforms module sends the email on line 1770 of webform.module (current release as of this writing). The FROM value submitted in my case is in the format

"Form Title" <user@domain.com>

which is actually SMTP standard. But for some reason it's not working. When I look at smtp.module, starting on line 285 (yesterday's dev snapshot), I see that SMTP appears to be pulling information from the headers instead of using the FROM value submitted as one of the drupal_mail parameters.

Maybe it would be a good idea to have SMTP check to see if a from address is present in the list of arguments proper before pulling data from the headers array which may not have a FROM if the caller assumes it will use the FROM argument from drupal_mail() call.

> What did you do to force PHPMailer to find the language file?

I don't think my PHP Path is set up properly for PHP to find the language file quite right. Just to prove it was the language file I added the SetLanguage PHPMailer command line to smtp.module right after the following line in drupal_mail_wrapper() (smtp.module file). So the code looks like this:

$mail = new PHPMailer();
$mail->SetLanguage("en", drupal_get_path('module', 'smtp') .'/phpmailer/language/');

As the architect, if you would like to completely avoid that problem in the future, you could probably do something similar on that line, but get the drupal language setting also. I'm not sure how you would do that. I don't know if the global $language variable is in context at that point in the code's execution, but you probably know more about that than I do.

Regarding the FROM issue, I uncommented the lines you mentioned and the submission went through fine. So that worked. I'm glad you drew my attention to those commented lines. Thanks! And it makes sense to me, looking at your regular expression that that's what should happen, because 2 lines down you have:

$mail->From     = '"'. $from_name .'" <'. $from .'>';

If $from was a standard SMTP formatted email address with a name, like "Name" <email@address.com>, then with those lines commented, your rewriting it to be "Name" <"Name" <email@address.com>>.

I think you should do a preg_match to see what format the $from value is in before using those 2 lines. If the email address is in the format "/^"\w+" <.*>$/", then those two lines should be used, if its in the format "/^<.+>$/" or the format of a regular email address, then they shouldn't.

I think there are really only those possibilities... and I haven't tested those regexes. Their just off the top of my head, so they may need to be tweaked.

Thanks for your help!

Okay, here's my recommended fix:

inside drupal_mail_wrapper(), I replaced these lines:

/** TODO: Check to see if the following will help or not */
//  $from_name = preg_replace("/\"(.*)\"(.*)/i", "$1", $from); // It gives: Name
//  $from      = preg_replace("/(.*)\<(.*)\>/i", "$2", $from); // It gives: name@domain.tld

with these lines:

  // get $from address out of a standard SMTP formatted Recipient string if necessary
  $valid_email_regex = '[a-z0-9_\+-]+(\.[a-z0-9_\+-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*\.([a-z]{2,4})';
  if(preg_match('/".+"\ \<'.$valid_email_regex.'\>/i',$from)) {
    $from = preg_replace("/(.*)\<(.*)\>/i", "$2", $from); // It gives: name@domain.tld
    $from_name = preg_replace('/"(.*)"(.*)/', "$1", $from); // It gives: Name
  } else if(preg_match('/^'.$valid_email_regex.'$/i',$from)) {
    // email address is already valid... no action necessary.
  } else {
    // TODO: throw error because the email FROM address is not a valid email address
  }
  // make sure there is something in the from name field
  $from_name = ($from_name) ? $from_name:$from;

2 suggestions are:

1. Allow the admin to set the valid email regex through the admin panel. (Don't know how to do that or I would post code for that too.)

2. Write the code to throw an error if the email recipient doesn't match... A better place to throw an error would be any place the email address is entered. But since the SMTP module probably can't control other modules where email addresses can be entered, that might not be practical without some global logic to validate email addresses inside drupal. So I'm not sure where we would go with that.

Changing status to patch (code needs review).

That's great news! It pays to know the API, doesn't it!

Thanks for your help, and for letting me participate. :o)