removing <br> from code

Posted by giorgio79 on July 12, 2008 at 9:55am

Issue Summary

Hi,

I noticed these lines 154, 167 contain the following code:

$links .= "
\n"; //if we don't display links then align horizontally the icons

I think
s should not be used for styling, such as aligning icons horizontally for css.

I propose to remove those lines and use css instead.

IT is easy to align them horizontally like this for example:

#block-addtofavorites-0 a
{
text-align:center;
margin:0 auto;
padding:15px
}

Posted by thierry_gd on July 28, 2008 at 8:23pm

Version:

5.x-1.x-dev

» 5.x-1.x-dev

Hi Giorgio79,

Could you describe more the solution you propose.

Thierry

Posted by giorgio79 on July 29, 2008 at 5:25am

Hi Thierry,

Sure, I just notice that I did not put comments around my code, hence they look funky in the first description.

So the lines 154,167 in addtofavorites.module file
$links .= "<br />\n"; //if we don't display links then align horizontally the icons

should be commented out like this

//$links .= "<br />\n"; //if we don't display links then align horizontally the icons

because <br /> s in this case are used for styling but this should be controlled by css.

Some people would like these to align horizontally, while others like me want this vertically :)

An even better solution would be to output this as a ul list :)