Active
Project:
Project issue tracking
Version:
5.x-2.x-dev
Component:
Comments
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2008 at 12:56 UTC
Updated:
26 Jan 2009 at 16:53 UTC
The phpdoc parameters includes a $view parameter that's not actually present in the function signature. We need to figure out what happened here. Probably $view is no longer a parameter, since I don't see the variable used in the actual function.
/**
* Calculate the differences in project_issue comment metadata
* between the original issue and a comment or between two
* comments.
*
* @param $view
* A string representing the metadata view being generated. For the comment
* metadata table, this will be 'diff'.
* @param $node
* The issue node.
* @param $old_data
* Object containing old metadata.
* @param $new_data
* Object containing new metadata.
* @param $field_labels
* An associative array of field_name=>display_name pairs.
* In most cases, this will be the array returned by project_issue_change_summary().
*
* @return
* An associative array containing information about changes between
* the two objects.
....
function project_issue_metadata_changes($node, $old_data, $new_data, $field_labels = array()) {}
Comments
Comment #1
mr.baileysAs far as I can trace back though the CVS logs, there never was a $view-parameter for this function. The function was added to project_issue.module between revs 1.87 & 1.88 (see diff) via the patch in #219734: Allow theming of changes in project issue table and email (unless the function was copied from elsewhere in which case I lost track...).
Comment #2
aclight commentedYeah, I think it was a parameter in one of the patches made before this got committed, but then we reworked things and removed that as a parameter but forgot to fix the phpdoc.