I changed error reporting to E_ALL in D5 and found some PHP notices in FeedAPI.

CommentFileSizeAuthor
#2 feedapi_5x_php_notices.patch5.25 KBalex_b
feedapi_5x_php_notices.patch4.65 KBmustafau

Comments

mustafau’s picture

mustafau commented
Priority: Normal » Critical

Critical since this patch fixes part of #288114: Errors when story type not present, when importing types with content copy.

alex_b’s picture

alex_b commented
StatusFileSize
new feedapi_5x_php_notices.patch5.25 KB

Reviewed patch. Looks good, I added the check for existing 'story' content type from #288114 and rerolled. Any observations on this patch in the meantime? Otherwise good to be committed and ported to 6.

alex_b’s picture

alex_b commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed. Needs to be ported to 6.x

alex_b’s picture

alex_b commented
Title: PHP notices in FeedAPI 5.x-1.x » PHP notices in FeedAPI

This patch overlaps with http://drupal.org/node/276996 - at least the default content type handling in feedapi_node doesn't though.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Patch (to be ported) » Fixed

I also fixed various php notices in both branch.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.