Line 335 of uc_paypal.module, which currently reads drupal_set_message(t('The credit card type did not pass validation.', 'error'));

It should actually be:
drupal_set_message(t('The credit card type did not pass validation.'), 'error');

This causes errors on checkout, such as:

* warning: Invalid argument supplied for foreach() in /var/www/drupal-5.7/includes/common.inc on line 747.
* warning: strtr() [function.strtr]: The second argument is not an array. in /var/www/drupal-5.7/includes/common.inc on line 762.
* We were unable to process your credit card payment. Please verify your card details and try again. If the problem persists, contact us to complete your order.

I would have submitted a patch but this is based on the hourly Bazaar checkout for D5 and I'm not sure what to diff against.

Comments

rszrama’s picture

rszrama commented
Assigned: Unassigned » rszrama
Status: Active » Fixed

No worries on the patch. Should be fixed now. Thanks for digging it up! : )

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

gravit’s picture

gravit commented
Status: Closed (fixed) » Active

Hi Ryan -

I just noticed This same issue is located in the uc_cybersource module - remnants of a copy and paste on Line 143. And while we're at it - we should change line 144's watchdog function to pass "uc_cybersource" instead of "uc_paypal"

Thanks!

rszrama’s picture

rszrama commented
Status: Active » Fixed

lol What a goof. Thanks, I fixed them both. : )

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.