Using uc_userpoints_discount a user can use all of there points (say $50) on any order even if the total is less (say $30) passing a $20 refund to the customer.

This could be the same or similar to http://drupal.org/node/254785

Comments

bmagistro’s picture

bmagistro commented
Status: Active » Postponed (maintainer needs more info)

That is something I never thought about. First thought that comes to my mind is to not allow it to be the same the order total, if they are going to use the order total amount then they should just pay with points. Any thoughts?

The balance not checked bug was something different. If you only had 3 points it would let you spend 30 and go negative but that has been fixed. This is a new one. I haven't used the discount module just coded it and did some basic testing. Thanks for trying it all out.

speedracer79’s picture

speedracer79 commented

I had not planned on using the points as payment part of the module. I think not allowing it to be the same the order total is the correct path to take. You could even make it a variable eg. some might only let you use points up to 50% of the total. Just a thought. I would be happy with it just not giving the refund.

bmagistro’s picture

bmagistro commented

I like that idea of making it configurable. I am pretty sure I know how to code that right now and will work on it tomorrow. If I do code the discount % in there any thoughts on what a reasonable discount would be or set it to 100% by default and let them go down from there? Thanks for the input.

speedracer79’s picture

speedracer79 commented

I think you start with 100%. I was just thinking that some people might not want to fill orders for $0

bmagistro’s picture

bmagistro commented
Status: Postponed (maintainer needs more info) » Active

Well I am stuck at the moment. I cannot seem to figure out how to validate data being entered on that page and get it to affect the order process.

bmagistro’s picture

bmagistro commented

This will be fixed in the next dev update, I have a new bug, they cannot go back and change the amount correctly.

bmagistro’s picture

bmagistro commented

Jurgen8en had made an attempted fix for this issue and I have finally been able to access the CVS and post it. It is in the D5 Dev. If someone could please test and confirm that would be greatly appreciated.

savmac’s picture

savmac commented

I am trying to streamline our checkout process and avoid using both the userpoints_discount module and the userpoints_payment module at the same time. Depending on whether the user has points that are less than or more than their order total, they have to use one module or the other.
I was thinking that if the discount module could be setup similar to the uc_free_order, then the payment module could be dropped all together if the total discount allowed was 100%.
i.e. allow user to apply points to discount their total by 100% on the checkout page if they have sufficient points and then they could pass right on through to review their order.
I think this would cause less confusion for the users as well if you are currently using both modules and the user has to decide whether they need to use their points as a payment or a discount.
I think the only change needed in the discount module is to allow the user to apply their discount while in checkout so that their total can drop to 0 (just like the uc free order module).
Thanks for the great modules!!! (using version 6.x-2.x-dev)

phacts’s picture

phacts commented

I'm having the same issue as savmac, basically it looks like this:

I've enabled userpoints_discount (using 6.x-2.x-dev), and it works nicely. However, if I try to use $2 worth of Userpoints on an order with a total of $2, I get an error saying "You cannot discount an order for more than the order total."

I understand what is happening, and I think this could be easily fixed if there was an "Apply to order" button underneath the Userpoints discount text field. This would update the order total (subtracting out the userpoints), and then a module like uc_free_order could do it's magic and allow for a purchase of $0.

Any hope of this getting implemented in the foreseeable future?

- Steve

bmagistro’s picture

bmagistro commented
Status: Active » Closed (won't fix)

Marking closed, won't fix as D5 is EOL. Issue should eventually be resolved in future versions >= D6 if it has not already been resolved.

@savmac
@phacts
This thread was for the 5.x version. There are several discount issues out there for D6 and I should be getting to them eventually. (I hope).