Discount larger than total order
speedracer79 - July 15, 2008 - 01:19
| Project: | Ubercart Userpoints |
| Version: | 5.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
Using uc_userpoints_discount a user can use all of there points (say $50) on any order even if the total is less (say $30) passing a $20 refund to the customer.
This could be the same or similar to http://drupal.org/node/254785
#1
That is something I never thought about. First thought that comes to my mind is to not allow it to be the same the order total, if they are going to use the order total amount then they should just pay with points. Any thoughts?
The balance not checked bug was something different. If you only had 3 points it would let you spend 30 and go negative but that has been fixed. This is a new one. I haven't used the discount module just coded it and did some basic testing. Thanks for trying it all out.
#2
I had not planned on using the points as payment part of the module. I think not allowing it to be the same the order total is the correct path to take. You could even make it a variable eg. some might only let you use points up to 50% of the total. Just a thought. I would be happy with it just not giving the refund.
#3
I like that idea of making it configurable. I am pretty sure I know how to code that right now and will work on it tomorrow. If I do code the discount % in there any thoughts on what a reasonable discount would be or set it to 100% by default and let them go down from there? Thanks for the input.
#4
I think you start with 100%. I was just thinking that some people might not want to fill orders for $0
#5
Well I am stuck at the moment. I cannot seem to figure out how to validate data being entered on that page and get it to affect the order process.
#6
This will be fixed in the next dev update, I have a new bug, they cannot go back and change the amount correctly.
#7
Jurgen8en had made an attempted fix for this issue and I have finally been able to access the CVS and post it. It is in the D5 Dev. If someone could please test and confirm that would be greatly appreciated.